Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dashboards): Update TimeseriesData types to always include meta #84478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Feb 3, 2025

As of recent changes to the backend, all timeseries requests to the backend return the meta property. Here I am updating the types to make future code simpler. I can also remove redundant checks sometime soon in another PR.

As of recent changes to the backend, all timeseries requests to the
backend return the `meta` property.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Bundle Report

Changes will increase total bundle size by 63 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.14MB 63 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.8a1256011e006fd5fbaa.js (New) 94.63kB 94.63kB 100.0% 🚀
chunks/app_components_breadcrumbs_tsx-app_components_feedback_widget_us*kWidget_tsx-app_utils-df50cf.ad8e9a5f40595a1d277b.js (New) 57.12kB 57.12kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--64a49b.b505c6136607e8767be1.js (New) 37.72kB 37.72kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.a031264b8ddb28db8f18.js (New) 37.17kB 37.17kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.79a956824e824a11b064.js (New) 31.93kB 31.93kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.024d996b2a8385651fd7.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.91e2f9e8e05bd0ca14fa.js (New) 17.01kB 17.01kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.3b91e1f26bbcd0ad091d.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.73df0d2f51e9590d89e8.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.d5acca6fee93d5822b9a.js (New) 12.25kB 12.25kB 100.0% 🚀
chunks/app_actionCreators_prompts_tsx-app_components_feedback_widget_us*k_tsx-app_components_-5240c4.01c925368685435c20b5.js (New) 12.12kB 12.12kB 100.0% 🚀
chunks/app_views_dashboards_widgets_bigNumberWidget_bigNumberWidget_stories_tsx.*.js 27 bytes 11.85kB 0.23%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.faec52e6b564f6e2f9ce.js (Deleted) -94.59kB 0 bytes -100.0% 🗑️
chunks/app_components_breadcrumbs_tsx-app_components_feedback_widget_us*kWidget_tsx-app_utils-df50cf.a027779959fd7d972e77.js (Deleted) -57.12kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--64a49b.26c00272c982c219c077.js (Deleted) -37.72kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.fa1125d7344b37da1124.js (Deleted) -37.17kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.e9d4843ffbd48cd277ae.js (Deleted) -31.93kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.c7df9e8f32f304d0d54e.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.1ff8928b71b35fc9f40b.js (Deleted) -17.01kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.d7fb68132cb3ba7d9ab1.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.3baf59e2bba3d7deaf5c.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.66d8890483a67db0a61a.js (Deleted) -12.25kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_prompts_tsx-app_components_feedback_widget_us*k_tsx-app_components_-5240c4.8d7ab5403bd309d9cef5.js (Deleted) -12.12kB 0 bytes -100.0% 🗑️

Files in chunks/app_views_dashboards_widgets_bigNumberWidget_bigNumberWidget_stories_tsx.*.js:

  • ./app/views/dashboards/widgets/bigNumberWidget/bigNumberWidget.stories.tsx → Total Size: 50.97kB

@gggritso gggritso marked this pull request as ready for review February 3, 2025 22:23
@gggritso gggritso requested review from a team as code owners February 3, 2025 22:23
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants