Skip to content

test(ci): Ignore annotation for pytest retries #27870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jul 30, 2021

Vendoring the pytest-github-actions-annotate-failures package until pytest-dev/pytest-github-actions-annotate-failures#30 is closed.

We will now ignore failures if there are retries pending. This will get rid of the GHA annotations that appear on test suites that pass.

Vendoring the `pytest-github-actions-annotate-failures` package until pytest-dev/pytest-github-actions-annotate-failures#30 is closed.

We will now ignore failures if there are retries pending. This will get rid of the GHA annotations that appear on test suites that pass.
Comment on lines +57 to +66
try:
# If we have the pytest_rerunfailures plugin,
# and there are still retries to be run,
# then do not return the error
import pytest_rerunfailures

if item.execution_count <= pytest_rerunfailures.get_reruns_count(item):
return
except ImportError:
pass
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks billy

@billyvg billyvg merged commit 74b6e21 into master Aug 2, 2021
@billyvg billyvg deleted the test/ci/do-not-annotate-pytest-failures-on-retries branch August 2, 2021 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants