Skip to content

feat(pr-iter): record the commits an iteration pushed - #124282

Draft
alexsohn1126 wants to merge 2 commits into
masterfrom
alexsohn/cw-2013-ci-after-iteration
Draft

feat(pr-iter): record the commits an iteration pushed#124282
alexsohn1126 wants to merge 2 commits into
masterfrom
alexsohn/cw-2013-ci-after-iteration

Conversation

@alexsohn1126

@alexsohn1126 alexsohn1126 commented Sep 14, 2026

Copy link
Copy Markdown
Member

Second of two. Stacked on #124281.

Adds head_shas to the feedback-batch analytics event: the commits an iteration pushed, filled only when the outcome is already_pushed. Joining it to ci_head_results on scm.pr.closed gives the CI outcome of a specific iteration.

No new CI event. ci_head_results already carries per-head outcomes (CW-1812 / CW-1850); what it cannot say is why Seer pushed a head. That is what this row adds, alongside trigger_source, automated_feedback_count and feedback_bot_logins — the gap CW-1813 called the metrics prerequisite for manual iteration.

Also moves the scan for the repositories an iteration changed into autofix_agent, shared with the push-outcome path.

Analyst notes: ci_head_results arrives only at PR close, behind organizations:pr-metrics, so an iteration on a PR that never closes has no CI row to join to.

Plan: ~/plans/20260911-cw-2013-bot-type-and-ci-metrics.md

https://claude.ai/code/session_01W2xkbxFqSJ2F5uUzrc5DXB

@alexsohn1126
alexsohn1126 added this pull request to stack #124283 September 14, 2026 14:44
@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

CW-2013

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 14, 2026
@alexsohn1126
alexsohn1126 force-pushed the alexsohn/cw-2013-ci-after-iteration branch from 8976713 to 9264e81 Compare September 14, 2026 14:59
@alexsohn1126

Copy link
Copy Markdown
Member Author

bugbot review
@sentry review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9264e81. Configure here.

@alexsohn1126
alexsohn1126 marked this pull request as ready for review September 14, 2026 15:11
@alexsohn1126
alexsohn1126 requested review from a team as code owners September 14, 2026 15:11
@alexsohn1126
alexsohn1126 marked this pull request as draft September 14, 2026 15:38
@alexsohn1126 alexsohn1126 changed the title feat(pr-iter): record the CI result after an iteration feat(pr-iter): record the commits an iteration pushed Sep 14, 2026
@alexsohn1126
alexsohn1126 force-pushed the alexsohn/cw-2013-ci-after-iteration branch from 417fad6 to 3373f28 Compare September 14, 2026 16:05
@alexsohn1126
alexsohn1126 force-pushed the alexsohn/cw-2013-ci-after-iteration branch 3 times, most recently from 036d546 to de77124 Compare September 14, 2026 16:52
@sentry

sentry Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 503 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Base automatically changed from alexsohn/cw-2013-review-bot-logins to master September 14, 2026 18:34
Adds head_shas to the feedback-batch analytics event and an event for a
concluded check suite. Together they let a CI result join to the batch
that pushed the commit. The scan for the repositories an iteration
changed moves to autofix_agent, so the push outcome and the analytics
row read it from one place.

Ref CW-2013.

Claude-Session: https://claude.ai/code/session_01W2xkbxFqSJ2F5uUzrc5DXB
Drops the check-suite event. ``head_shas`` joins to the per-head CI
results already emitted on ``scm.pr.closed``, so the CI outcome of an
iteration is a query rather than a second event stream.

Claude-Session: https://claude.ai/code/session_01W2xkbxFqSJ2F5uUzrc5DXB
@alexsohn1126
alexsohn1126 force-pushed the alexsohn/cw-2013-ci-after-iteration branch from de77124 to ff542c3 Compare September 14, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant