Repository navigation
feat(seer): Add monitor cleanup workflow UI - #123978
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 3 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
Contributor
Sentry Snapshot Testing
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
trevor-e
force-pushed
the
telkins/codex/monitor-cleanup-demo
branch
from
September 14, 2026 18:41
4a7d6a7 to
2d8185c
Compare
trevor-e
force-pushed
the
telkins/codex/monitor-cleanup-ui
branch
from
September 14, 2026 18:43
23f7fc5 to
983b95e
Compare
github-actions
Bot
added
the
Scope: Backend
github-actions
Bot
removed
the
Scope: Backend
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 787dced. Configure here.
trevor-e
added a commit
that referenced
this pull request
Sep 15, 2026
Adds a top-level nullable `source` field to workflow run responses, using a shared `WorkflowRunSource` literal type (`cron` or `manual`). Reuses Night Shift’s existing `extras.options.source`; monitor scan callers pass the source explicitly, with the user-facing endpoint passing `manual`. Runs without a recorded source return `null`. Backend prerequisite for #123978. The existing Night Shift extras remain available for older clients. Existing history tests cover recorded and unknown sources, and preserving source through scan completion.
jshchnz
approved these changes
Sep 15, 2026
trevor-e
marked this pull request as ready for review
September 15, 2026 16:11
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+143
to
+146
| Array.from(new Set(runs.map(run => run.strategy))).map(strategy => ({ | ||
| value: strategy, | ||
| label: STRATEGY_META[strategy].label, | ||
| })), |
Contributor
There was a problem hiding this comment.
Bug: Unsafe property access on STRATEGY_META using an unvalidated strategy key from an API response can cause a runtime crash if the key is unknown.
Severity: HIGH
Suggested Fix
Implement runtime validation for the API response, for instance with a Zod schema. Alternatively, use optional chaining (STRATEGY_META[strategy]?.label) and provide a fallback value (e.g., ?? 'Unknown Strategy') to gracefully handle cases where an unknown strategy is received from the API, preventing a crash.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/app/views/seerWorkflows/index.tsx#L143-L146
Potential issue: The code uses the `strategy` string from an API response to access
properties on the `STRATEGY_META` object. There is no runtime validation to ensure the
`strategy` value from the API is a valid key in `STRATEGY_META`. If the API returns an
unexpected or new strategy string, the lookup `STRATEGY_META[strategy]` will result in
`undefined`. The subsequent access to the `.label` property will throw a `TypeError`,
causing a runtime crash. This could occur due to API version mismatches or a backend
bug.
Also affects:
static/app/views/seerWorkflows/index.tsx:424~426
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
will handle in follow-up, not an issue rn
3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flag-gated “Run…” menu to the Autofix workflows page, initially offering a monitor scan. Runs update with findings, property comparisons, monitor and alert links, and agent debug links. Incomplete and unsupported results remain distinct from completed scans with no findings; users follow monitor links to delete duplicates.
The page consumes strategy-specific API run types directly, sharing polling and filtering while deriving display status and summaries per strategy. Trigger source comes from the API; unknown sources display
--. Uses the execution backend from #123966 (merged) and requires the source field from #124379 to land first.