fix(clipboard): Prevent unhandled promise rejection from NotAllowedError - #121032
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(clipboard): Prevent unhandled promise rejection from NotAllowedError#121032sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-g1wt2iv6v.sentry.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue JAVASCRIPT-3B6G, where
NotAllowedErrorfromnavigator.clipboard.writeText()was causing unhandled promise rejections.Root Cause:
The
copyToClipboardfunction inuseCopyToClipboard.tsxwould re-throw theNotAllowedErrorafter displaying an error toast. Since many callers usecopy(...)in a fire-and-forget manner without chaining a.catch(), this re-throw resulted in unhandled promise rejections being reported to Sentry.Changes:
static/app/utils/useCopyToClipboard.tsx:throw errorfrom the.catch()block. The error toast already provides user feedback, so re-throwing is unnecessary and causes the unhandled rejection.CopyCallbackandcopyToClipboardreturn types toPromise<string | void>to reflect that the promise now resolves (tovoid) on a clipboard error, rather than rejecting.static/app/components/copyToClipboardButton.tsx:.then()handler to explicitly check if the resolved value isundefined. If it is, it indicates a copy failure (where the error was handled internally bycopyToClipboard), and theonErrorcallback is now invoked with a generic error. This maintains the expectedonErrorbehavior for components usingCopyToClipboardButton.CI Fixes:
errorparameter to_errorinuseCopyToClipboard.tsxto resolve a TypeScriptTS6133error.copyToClipboardButton.tsxto address an ESLintunicorn/no-negated-conditionerror.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-3B6G
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.