Skip to content

fix(seerExplorer): Handle localStorage access in Safari private mode #121031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Draft

fix(seerExplorer): Handle localStorage access in Safari private mode #121031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/views/seerExplorer/components/sidebar/seerExplorerSidebarLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import styled from '@emotion/styled';
import {Stack} from '@sentry/scraps/layout';
import {SplitPanel, type SplitPanelHandle} from '@sentry/scraps/splitPanel';

import {localStorageWrapper} from 'sentry/utils/localStorage';
import {useDimensions} from 'sentry/utils/useDimensions';
import {SeerExplorerPanel} from 'sentry/views/seerExplorer/components/sidebar/seerExplorerPanel';
import {useSeerExplorerContext} from 'sentry/views/seerExplorer/useSeerExplorerContext';
Expand Down Expand Up @@ -67,7 +68,7 @@ function SeerExplorerSidebarLayoutInSidebarMode({children}: {children: React.Rea
const defaultSeerSize = isRight ? DEFAULT_SEER_WIDTH : DEFAULT_SEER_HEIGHT;
const seerSizeKey = SEER_EXPLORER_SIDEBAR_SEER_SIZE_KEY[orientation];

const storedSeerSize = parseInt(localStorage.getItem(seerSizeKey) ?? '', 10);
const storedSeerSize = parseInt(localStorageWrapper.getItem(seerSizeKey) ?? '', 10);
const seerSize = storedSeerSize > 0 ? storedSeerSize : defaultSeerSize;

// The app (sized) pane size = available − Seer's size, floored at `minContent`
Expand Down Expand Up @@ -96,7 +97,7 @@ function SeerExplorerSidebarLayoutInSidebarMode({children}: {children: React.Rea
return;
}
const seer = Math.max(minSeer, available - contentEndSize);
localStorage.setItem(seerSizeKey, String(Math.round(seer)));
localStorageWrapper.setItem(seerSizeKey, String(Math.round(seer)));
};

// Let the routed app content scroll within its own pane instead of growing the
Expand Down
Loading