-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ref(seer): remove redundant SeerViewerContext from endpoint call sites #121021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sehr-m
wants to merge
3
commits into
master
Choose a base branch
from
sehr/viewer-context-endpoint-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background continue_run callers lose X-Viewer-Context header to Seer
Dropping
viewer_context=self.viewer_contexthere also strips the viewer header for task/consumer callers ofSeerExplorerClient.continue_run(e.g.dashboards/on_completion_hook.py,seer/autofix/autofix_agent.py,seer/entrypoints/operator.py), where the middleware contextvar is not set — contradicting the PR's claim that task call sites keep a fallback — so Seer receives those requests with no org/user attribution.Evidence
SeerExplorerClient.continue_runnow callsmake_agent_chat_request(chat_body)with noviewer_context, and the same pattern applies tomake_agent_runs_request/make_agent_update_request(client.py:903,975)._resolve_viewer_context(None)insigned_seer_api.py:56returnsget_viewer_context(), which isNoneoutside request middleware; when resolved is None theX-Viewer-Contextheader is simply not added (make_signed_seer_api_request).continue_runis called from non-endpoint paths:dashboards/on_completion_hook.py:262(task, builds client withuser=None),seer/autofix/autofix_agent.py:485, andseer/entrypoints/operator.py:553, none of which are covered byViewerContextMiddleware.self.viewer_context(built from the client's organization/user) was always sent, so Seer-side attribution/scoping was preserved even in background contexts; the PR body states VC is not yet hoisted at task/consumer boundaries.Identified by Warden · security-review · 37R-U7N