Skip to content

feat(preprod): Add install groups to EAP items #121019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jamieQ wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Draft

feat(preprod): Add install groups to EAP items #121019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/preprod/eap/write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def produce_preprod_size_metric_to_eap(
"build_configuration_name": (
artifact.build_configuration.name if artifact.build_configuration else None
),
"install_groups": artifact.extras.get("install_groups") if artifact.extras else None,
}

if artifact.commit_comparison is not None:
Expand Down Expand Up @@ -199,6 +200,7 @@ def produce_preprod_build_distribution_to_eap(
"build_configuration_name": (
artifact.build_configuration.name if artifact.build_configuration else None
),
"install_groups": artifact.extras.get("install_groups") if artifact.extras else None,
}

if artifact.extras:
Expand Down
12 changes: 12 additions & 0 deletions tests/sentry/preprod/eap/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def test_write_preprod_size_metric_encodes_all_fields_correctly(self, mock_produ
commit_comparison=commit_comparison,
build_configuration=build_config,
date_built=datetime(2024, 1, 1, 10, 0, 0, tzinfo=dt_timezone.utc),
extras={"install_groups": ["alpha", "beta"]},
)
self.create_preprod_artifact_mobile_app_info(
preprod_artifact=artifact,
Expand Down Expand Up @@ -115,6 +116,10 @@ def test_write_preprod_size_metric_encodes_all_fields_correctly(self, mock_produ
assert attrs["artifact_date_built"].int_value == int(artifact.date_built.timestamp())

assert attrs["build_configuration_name"].string_value == "Release"
assert [value.string_value for value in attrs["install_groups"].array_value.values] == [
"alpha",
"beta",
]

assert attrs["git_head_sha"].string_value == "abc123"
assert attrs["git_base_sha"].string_value == "def456"
Expand Down Expand Up @@ -160,6 +165,7 @@ def test_write_preprod_size_metric_handles_optional_fields(self, mock_produce):
assert "min_install_size" not in attrs
assert "max_install_size" not in attrs
assert "build_configuration_name" not in attrs
assert "install_groups" not in attrs
assert "git_head_sha" not in attrs


Expand Down Expand Up @@ -201,6 +207,7 @@ def test_write_preprod_build_distribution_encodes_all_fields_correctly(self, moc
"is_simulator": False,
"has_missing_dsym_binaries": True,
"has_proguard_mapping": False,
"install_groups": ["alpha", "beta"],
},
)
self.create_preprod_artifact_mobile_app_info(
Expand Down Expand Up @@ -256,6 +263,10 @@ def test_write_preprod_build_distribution_encodes_all_fields_correctly(self, moc
assert artifact.date_built is not None
assert attrs["artifact_date_built"].int_value == int(artifact.date_built.timestamp())
assert attrs["build_configuration_name"].string_value == "Release"
assert [value.string_value for value in attrs["install_groups"].array_value.values] == [
"alpha",
"beta",
]

assert attrs["codesigning_type"].string_value == "AdHoc"
assert attrs["profile_name"].string_value == "Development Profile"
Expand Down Expand Up @@ -309,5 +320,6 @@ def test_write_preprod_build_distribution_handles_optional_fields(self, mock_pro

assert "codesigning_type" not in attrs
assert "profile_name" not in attrs
assert "install_groups" not in attrs
assert "build_configuration_name" not in attrs
assert "git_head_sha" not in attrs
Loading