WIP - seer settings for migrating orgs #106931
Draft
+201
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| <Tabs value={tab} onChange={setTab}> | ||
| <TabList> | ||
| <TabList.Item key="repos">{t('Settings')}</TabList.Item> | ||
| <TabList.Item key="settings">{t('Repos')}</TabList.Item> |
Contributor
There was a problem hiding this comment.
Tab labels are swapped with their keys
High Severity
The TabList.Item labels are swapped with their keys. The item with key="repos" displays the label "Settings", while key="settings" displays "Repos". Since the content rendering correctly shows SeerRepoTable when tab === 'repos' and SeerAutomationProjectList when tab === 'settings', clicking the "Settings" tab will actually display the repos table, and clicking "Repos" will display the project settings content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/getsentry/issue/CW-679/help-existing-seer-orgs-onboard-into-code-review-before-updating