feat(select): Introduce 'menuPlacement=auto' by default for all selects #102067
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| return <Component ref={ref as any} {...props} />; | ||
| return <Component ref={ref as any} {...props} menuPlacement="auto" />; |
There was a problem hiding this comment.
Bug: Default Prop Overriding User Input
The menuPlacement="auto" prop is placed after {...props}, causing it to override any menuPlacement value passed in props instead of serving as a default. This prevents users from customizing the menu placement.
There was a problem hiding this comment.
bingo. that is what we want!
TkDodo
approved these changes
Oct 25, 2025
priscilawebdev
deleted the
priscila/feat/select/make-menu-placement-auto-for-all-selects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we decided to introduce the prop menuPlacement="auto" as the default behavior for ReactSelect (see).
However, I noticed through the PR that this default was not being applied when the component was a CreatableSelect.
This PR fixes that issue, making
menuPlacement="auto"the default for all select components.