feat(theme): avoid flash of inaccurate theme in SPA mode #102045
Merged
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Flash of inAccurate coloR Theme = `FART`](https://css-tricks.com/flash-of-inaccurate-color-theme-fart/)
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
JonasBa
reviewed
Oct 24, 2025
JonasBa
reviewed
Oct 24, 2025
JonasBa
reviewed
Oct 24, 2025
Co-authored-by: Jonas <[email protected]>
JonasBa
approved these changes
Oct 24, 2025
natemoo-re
added a commit
that referenced
this pull request
Oct 24, 2025
I accidentally merged some broken response logic in #102045. This fixes it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
pnpm dev-uiand Vercel preview deployments reflect user theme preferencesBy inlining a small script to the
index.ejstemplate, we can avoid Flash of inAccurate coloR Theme (akaFART). Unfortunately, the theme is asynchronously fetched, but by defaulting tobody.theme-system, the likelihood of an unstyled flash should be greatly reduced.