Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update minimum supported Electron version #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 20, 2025

The recently released v6.0.0 of the Electron SDK bumps the minimum supported version of Electron to v23.

It looks like we didn't update this for the last major version!

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.50%. Comparing base (9edc8a5) to head (c7e266d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   49.72%   49.50%   -0.23%     
==========================================
  Files          52       52              
  Lines        3505     3505              
  Branches      823      812      -11     
==========================================
- Hits         1743     1735       -8     
- Misses       1627     1769     +142     
+ Partials      135        1     -134     
Flag Coverage Δ
e2e-tests 78.46% <ø> (-6.16%) ⬇️
unit-tests 48.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants