ref!: Follow up to Node v18 changes #797
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
==========================================
- Coverage 50.21% 49.72% -0.49%
==========================================
Files 52 52
Lines 3529 3505 -24
Branches 880 812 -68
==========================================
- Hits 1772 1743 -29
- Misses 1756 1761 +5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| }, | ||
| ) => Promise<childProcess.ChildProcess>; | ||
|
|
||
| export { opn }; |
There was a problem hiding this comment.
Since we don't add a type cast to opn anymore, can we get rid of this export and import from 'opn' directly wherever we need it?
There was a problem hiding this comment.
Good idea but I'd do that later?
| "skipLibCheck": true, | ||
| "types": [], | ||
| "experimentalDecorators": true, | ||
| "emitDecoratorMetadata": true, | ||
| "sourceMap": true, | ||
| "inlineSources": true, | ||
| "resolveJsonModule": true | ||
| "resolveJsonModule": true, |
There was a problem hiding this comment.
l: since we no longer require the package.json to read the CLI version, can we get rid of resolveJsonModule (IIRC it defaults to false).
edit: Actually not sure if we require a json somewhere else, so feel free to ignore
There was a problem hiding this comment.
Will do this in a follow up, already planned :)
Split off from #796