feat(flutter): Add Flutter support #735
Conversation
# Conflicts: # CHANGELOG.md
|
@buenaflor Ready for the first review/feedback round :) |
There was a problem hiding this comment.
Hey, leaving a first pass review for general wizard recommendations. This is not technical as I have very little to no context around Flutter.
- Ideally, we can make the SDK features selectable from the start as we've done recently with the JS-SDK wizards. See Make Sentry features selectable in wizard #558
- Great to see some tests for this flow! :) I recommend adding an e2e test app as well as this proved quite useful for our other wizards.
Feel free to disregard my advice as I'll happily leave the final call to the mobile team. Don't want to block you, just share some recommendations :)
…o feat/flutter-support # Conflicts: # CHANGELOG.md
|
@denrase e2e test is failing |
| const { selectedProject, selfHosted, sentryUrl, authToken } = | ||
| await getOrAskForProjectData(options, 'flutter'); | ||
|
|
||
| const projectDir = process.cwd(); |
There was a problem hiding this comment.
Not sure if it applies (if it's common users have old outdated apps), but we could check min dart and flutter versions before the wizard starts patching.
There was a problem hiding this comment.
I'd leave it for now if it's ok with you. Users will see an error when versions are resolved, so my feeling is we don't need to do this just to have it run a couple of seconds sooner.
|
Added some comments based on my experience with RN Wizard. |
|
@krystofwoldrich Neat, thx for the feedback! 🙇♂️ |
# Conflicts: # README.md
|
@krystofwoldrich could you take another looks pls 🙏 |
main.dartwith import, sentry setup and sample snippetpubspec.yamlwith sentry_flutter dependency and plugin to upload debug symbols and source mapsCloses getsentry/sentry-dart#2424
Relates to #558