Skip to content

Switch the existing Sentry classes to use USTRUCTs #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tustanivsky
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Switch the existing Sentry classes to use USTRUCTs ([#854](https://github.com/getsentry/sentry-unreal/pull/854))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against bee2cd5

ESentryLevel GetLevel() const;

/** Retrieves the underlying native implementation. */
TSharedPtr<ISentryBreadcrumb> GetNativeObject() const { return NativeImpl; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it seems odd that we ever expose this. Perhaps we can remove the need for this and any public callers can use a different method? For example, we use GetNativeObject() to call sentry_value_set_stacktrace - perhaps instead we have a method on the the Sentry event called AddStacktrace and that calls the method underneath?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. There are definitely a few use cases where we can remove GetNativeObject() and route calls to underlying SDKs through our Unreal wrappers directly. I'll look into this and see if it's something we can achieve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants