Add Command Line Arguments to DefaultContext

[jayhf]

The command line arguments seem like a really useful piece of information to have when debugging crashes. This adds them to the DefaultContext so that they're readily available in Sentry

[tustanivsky]

Hey @jayhf, I believe we're already adding the command line input to Crash Info context on Win/Linux for captured crash events:

sentry-unreal/plugin-dev/Source/Sentry/Private/Desktop/CrashReporter/SentryCrashContext.cpp

Line 54 in 982894b

ContextValues.Add("Command Line", FString(SessionContext.CommandLine).TrimStart());

Does it miss some bits of info you expect to be there along with other CL arguments?

[jayhf]

Ah, that's great to know. I didn't realize. Where exactly can those context be found? I haven't seen any of those fields in the crash logs I'm analyzing. Are there any docs you'd recommend for what information is available where?

[tustanivsky]

The command line arguments can be found at captured crash event's page in Contexts -> Crash Info section in case you're using Sentry's plugin integration for error handling:

If you're sending crashes to Sentry with the default Crash Reporter instead then CL args should be listed in Contexts -> unreal -> custom.

Also, you can consider enriching the events with custom contexts via the plugin's API if the default one misses some bits of info you're interested in.

[jayhf]

Sorry for the slow response here. I think I've figured out why I wasn't seeing the information before: Most of the issues I'm encountering are assertion failures, which ultimately result in the process exiting, but aren't treated as crashes by the Sentry plugin. Interestingly, even the crash context records IsAssert, so this seems to be due to a bug or limitation of Sentry's plugin. Perhaps it's even a Linux specific issue. These two issues might be related: #381 and #496, but neither seems like exactly the issue I'm hitting. At any rate, this clearly isn't the right approach so I'll close the PR and I may follow up with an issue later.

[tustanivsky]

@jayhf Thank you for following up. Previously, we had to modify the engine's default assertion-capturing flow to resolve an issue with event grouping in Sentry. However, we are now exploring an alternative approach (#669) that should allow us to restore the original implementation.

[jayhf]

Makes sense. I'll keep an eye on that issue, thanks!