-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix latency related nil error for Sidekiq Queues module span data #2486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2486 +/- ##
==========================================
+ Coverage 98.17% 98.19% +0.02%
==========================================
Files 128 128
Lines 4827 4833 +6
==========================================
+ Hits 4739 4746 +7
+ Misses 88 87 -1
|
70fbad0
to
c7d6960
Compare
c7d6960
to
5c400f0
Compare
Hey @solnic, could I request this one get published as it impacts our production services? |
@swistaczek I can release tomorrow |
Thank you! |
Release is blocked due to CI issues with the ongoing jruby / jar-dependecies / psych mess. @solnic I'm OOO till next week now, could you maybe try to figure out and make a patch release? |
@sl0thentr0py sure, I'll figure it out and push a release |
OK it looks like we are really blocked with jruby-head crashing during bundling, I don't think there's an easy workaround so I just opened a PR that removes jruby-header from CI where it was failing to unblock a new release. Once the PR is merged, I'll push a release. |
@swistaczek released 5.22.1 now |
fixes #2485