Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latency related nil error for Sidekiq Queues module span data #2486

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Dec 5, 2024

fixes #2485

@sl0thentr0py sl0thentr0py requested a review from solnic December 5, 2024 13:46
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (1eb011b) to head (5c400f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2486      +/-   ##
==========================================
+ Coverage   98.17%   98.19%   +0.02%     
==========================================
  Files         128      128              
  Lines        4827     4833       +6     
==========================================
+ Hits         4739     4746       +7     
+ Misses         88       87       -1     
Components Coverage Δ
sentry-ruby 98.57% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.07% <ø> (ø)
sentry-sidekiq 97.42% <100.00%> (+0.45%) ⬆️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/span.rb 100.00% <100.00%> (ø)
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 100.00% <100.00%> (+1.78%) ⬆️

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-sidekiq-nil branch 2 times, most recently from 70fbad0 to c7d6960 Compare December 5, 2024 13:53
@sl0thentr0py sl0thentr0py merged commit 9d37d28 into master Dec 10, 2024
141 of 142 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-sidekiq-nil branch December 10, 2024 13:11
@swistaczek
Copy link
Contributor

Hey @solnic, could I request this one get published as it impacts our production services?

@sl0thentr0py
Copy link
Member Author

@swistaczek I can release tomorrow

@swistaczek
Copy link
Contributor

Thank you!

@sl0thentr0py
Copy link
Member Author

Release is blocked due to CI issues with the ongoing jruby / jar-dependecies / psych mess.
ruby/psych#700
#2490

@solnic I'm OOO till next week now, could you maybe try to figure out and make a patch release?
Otherwise, @swistaczek please use the last version (5.21.0) for now or point your gem to github (master).

@solnic
Copy link
Collaborator

solnic commented Dec 12, 2024

@sl0thentr0py sure, I'll figure it out and push a release

@solnic
Copy link
Collaborator

solnic commented Dec 12, 2024

OK it looks like we are really blocked with jruby-head crashing during bundling, I don't think there's an easy workaround so I just opened a PR that removes jruby-header from CI where it was failing to unblock a new release. Once the PR is merged, I'll push a release.

@sl0thentr0py
Copy link
Member Author

@swistaczek released 5.22.1 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling perform_inline with Sidekiq job causes error in set_span_data because enqueued_at is nil.
3 participants