-
-
Notifications
You must be signed in to change notification settings - Fork 356
AGENTS.md file added #5510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENTS.md file added #5510
Conversation
|
is this only internal or clients will also use it? |
My understanding is that this would be used both internally and externally since it is open. |
Does it make sense to add it to the changelog? |
|
@sentry review |
I do not have a strong opinion but I think not since it is targeting agents and not humans. Other platforms skipped the changelog too |
| - **Expo**: Managed workflow support | ||
| - **Sentry Cocoa**: iOS native SDK | ||
| - **Sentry Java/Android**: Android native SDK | ||
| - **Flutter**: Flutter SDK depends on native SDKs | ||
| - **.NET**: .NET MAUI depends on native SDKs | ||
| - **Unity**: Unity SDK depends on native SDKs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: shouldn't we only consider the impact on React Native and maybe cocoa/java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this. We may also need to add the Javascript SDK here
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a nit that I would avoid mentioning platforms unrelated to React Native.
Also, I am not familiar if the file size maters here. Other than that, thank youfor the PR!
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙇
📢 Type of change
📜 Description
Adds AGENTS.md, fixes #5499
The added file is partially based on https://github.com/getsentry/sentry-cocoa/blob/main/AGENTS.md
#skip-changelog