Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be nice, for cases like this when we develop a new major version of the SDK, but it won't work, since the updater action automatically detects the main branch.
https://github.com/getsentry/github-workflows/blob/cd1c852719aaf272f2730a2df1146dba80412ee3/.github/workflows/updater.yml#L130
We would have to allow to specify the base branch or allow mode where it takes as a base the current local HEAD and also make sure the PRs are not overwritten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I have validated on a local fork and this change wasn't merged. I will open an issue on github-workflows to see if there is any chance this could be supported.
I will close this PR if the issue is rejected, othewise, I will leave it open as a draft