(feat-V7) Log Tracing #4827

lucas-zimerman · 2025-05-13T14:22:05Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Blocked by:

📜 Description

Add the required changes on the Client in order to capture logs. All platforms will be supported with the initial PR (web, iOS and Android)

💡 Motivation and Context

Fixes #4856

💚 How did you test it?

Locally, with native SDKs disabled for testing the JavaScript integration, and with native SDKs enabled to test the Native integration

Pii

Pii seems to be filtered serverside so we don't need to do anything on the SDK.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Implement tests
Decide what todo with internal logs sent to logger. (Doesn't seems to be sent)
Redirect BeforeLog from native to JS Layer
Add documentation.

github-actions · 2025-05-13T14:40:23Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	473.64 ms	463.42 ms	-10.22 ms
Size	17.75 MiB	19.58 MiB	1.83 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9fbcfaf`	420.06 ms	435.31 ms	15.25 ms
`9da5c4e`	478.08 ms	467.46 ms	-10.63 ms
`fb6493a`	446.78 ms	441.65 ms	-5.13 ms
`8a54dff`	482.57 ms	467.16 ms	-15.41 ms

App size

Revision	Plain	With Sentry	Diff
`9fbcfaf`	17.75 MiB	19.54 MiB	1.79 MiB
`9da5c4e`	17.75 MiB	20.16 MiB	2.41 MiB
`fb6493a`	17.75 MiB	19.58 MiB	1.83 MiB
`8a54dff`	17.75 MiB	19.54 MiB	1.80 MiB

Previous results on branch: lz/v7-test-logs

Startup times

Revision	Plain	With Sentry	Diff
`b592bbd`	489.78 ms	487.25 ms	-2.53 ms
`ee79082`	439.09 ms	481.84 ms	42.75 ms

App size

Revision	Plain	With Sentry	Diff
`b592bbd`	17.75 MiB	19.56 MiB	1.82 MiB
`ee79082`	17.75 MiB	19.56 MiB	1.82 MiB

github-actions · 2025-05-13T14:59:26Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.33 ms	1228.20 ms	3.88 ms
Size	2.63 MiB	3.78 MiB	1.15 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	1231.84 ms	1235.49 ms	3.65 ms
`8a54dff`+dirty	1226.17 ms	1227.79 ms	1.63 ms
`9fbcfaf`+dirty	1216.66 ms	1212.06 ms	-4.60 ms
`fb6493a`+dirty	1222.42 ms	1235.50 ms	13.08 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	2.63 MiB	3.76 MiB	1.13 MiB
`8a54dff`+dirty	2.63 MiB	3.79 MiB	1.16 MiB
`9fbcfaf`+dirty	2.63 MiB	3.77 MiB	1.14 MiB
`fb6493a`+dirty	2.63 MiB	3.78 MiB	1.15 MiB

Previous results on branch: lz/v7-test-logs

Startup times

Revision	Plain	With Sentry	Diff
`ee79082`+dirty	1217.93 ms	1221.08 ms	3.15 ms
`b592bbd`+dirty	1219.21 ms	1232.27 ms	13.06 ms

App size

Revision	Plain	With Sentry	Diff
`ee79082`+dirty	2.63 MiB	3.76 MiB	1.13 MiB
`b592bbd`+dirty	2.63 MiB	3.76 MiB	1.13 MiB

github-actions · 2025-05-13T15:11:47Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1231.61 ms	1234.17 ms	2.56 ms
Size	3.19 MiB	4.35 MiB	1.16 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	1215.41 ms	1226.38 ms	10.97 ms
`8a54dff`+dirty	1244.29 ms	1254.71 ms	10.43 ms
`9fbcfaf`+dirty	1215.22 ms	1222.26 ms	7.04 ms
`fb6493a`+dirty	1229.61 ms	1221.21 ms	-8.40 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	3.19 MiB	4.33 MiB	1.14 MiB
`8a54dff`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`9fbcfaf`+dirty	3.19 MiB	4.34 MiB	1.15 MiB
`fb6493a`+dirty	3.19 MiB	4.35 MiB	1.16 MiB

Previous results on branch: lz/v7-test-logs

Startup times

Revision	Plain	With Sentry	Diff
`ee79082`+dirty	1223.58 ms	1225.13 ms	1.54 ms
`b592bbd`+dirty	1218.20 ms	1229.35 ms	11.14 ms

App size

Revision	Plain	With Sentry	Diff
`ee79082`+dirty	3.19 MiB	4.33 MiB	1.14 MiB
`b592bbd`+dirty	3.19 MiB	4.33 MiB	1.14 MiB

…into lz/v7-test-logs

…-react-native into lz/v7-test-logs

lucas-zimerman · 2025-05-22T14:42:47Z

logs are now correctly captured on Android,iOS and JS.

lucas-zimerman · 2025-05-26T17:39:53Z

build errors will be fixed on #4860

…into lz/v7-test-logs

…-react-native into lz/v7-test-logs

lucas-zimerman · 2025-05-27T10:42:31Z

packages/core/src/js/wrapper.ts

@@ -182,7 +182,7 @@ export const NATIVE: SentryNativeWrapper = {
          typeof itemHeader.content_type === 'string' ? itemHeader.content_type : 'application/octet-stream';
        bytesPayload = itemPayload;
      } else {
-        bytesContentType = 'application/json';
+        bytesContentType = 'application/vnd.sentry.items.log+json';


Should we use the new content type for all requests or only the ones that contain logs? @krystofwoldrich @kahest
This can create a break changes on self -hosted, and I am not sure which version has support for logging.

on Sentry JavaScript for example, they use application/vnd.sentry.items.log+json by default on all requests

github-actions · 2025-05-27T11:30:49Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	415.21 ms	441.44 ms	26.22 ms
Size	7.15 MiB	8.34 MiB	1.18 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9fbcfaf`+dirty	417.92 ms	431.81 ms	13.90 ms
`fb6493a`+dirty	352.12 ms	372.92 ms	20.80 ms
`8a54dff`+dirty	393.65 ms	392.32 ms	-1.33 ms
`9da5c4e`+dirty	399.70 ms	407.34 ms	7.64 ms

App size

Revision	Plain	With Sentry	Diff
`9fbcfaf`+dirty	7.15 MiB	8.29 MiB	1.14 MiB
`fb6493a`+dirty	7.15 MiB	8.33 MiB	1.18 MiB
`8a54dff`+dirty	7.15 MiB	8.30 MiB	1.15 MiB
`9da5c4e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB

Previous results on branch: lz/v7-test-logs

Startup times

Revision	Plain	With Sentry	Diff
`ee79082`+dirty	431.77 ms	430.77 ms	-1.00 ms
`b592bbd`+dirty	457.76 ms	478.40 ms	20.64 ms

App size

Revision	Plain	With Sentry	Diff
`ee79082`+dirty	7.15 MiB	8.32 MiB	1.17 MiB
`b592bbd`+dirty	7.15 MiB	8.32 MiB	1.17 MiB

lucas-zimerman · 2025-05-27T11:47:29Z

CHANGELOG.md

@@ -61,6 +84,10 @@ Version 7 of the SDK is compatible with Sentry self-hosted versions 24.4.2 or hi
 - `@sentry/utils` package, the exports were moved to `@sentry/core`
 - Standalone `Client` interface & deprecate `BaseClient`

+### Self Hosted
+
+- It is recommended to use Sentry Self Hosted version `24.8.0` this and future versions.


I validated that capture of events/exceptions are working on 24.8.0, but we should at least recommend the first version suggested here getsentry/self-hosted#3560

CHANGELOG.md

lucas-zimerman · 2025-05-27T12:07:27Z

CHANGELOG.md

@@ -61,6 +84,10 @@ Version 7 of the SDK is compatible with Sentry self-hosted versions 24.4.2 or hi
 - `@sentry/utils` package, the exports were moved to `@sentry/core`
 - Standalone `Client` interface & deprecate `BaseClient`

+### Self Hosted
+
+- It is recommended to use Sentry Self Hosted version `25.2.0` or new for React Native V7 or newer


this change affects all events/transactions due to the content type of the request being changed.

25.2.0 is a safe value for it getsentry/self-hosted#3560, even if we don't officially support logs, it'll not drop other types of content

samples/react-native/src/App.tsx

lucas-zimerman · 2025-05-28T14:55:29Z

@krystofwoldrich @antonis it's ready for review :D

antonis · 2025-05-29T08:39:05Z

CHANGELOG.md

+To enable it add the following code to your Sentry Options:
+
+```typescript
+  _experiments: {
+    enableLogs: true,
+  },
+```
+
+You can also filter the logs being collected by adding beforeSendLogs into `_experiments`
+
+```typescript
+  _experiments: {
+    enableLogs: true,
+    beforeSendLog: (log) => {
+      return log;
+    },
+  },
+  ```


nit: I think we should align one tab to the right

antonis

LGTM and worked as expected in my tests 🎸

lucas-zimerman changed the base branch from main to v7 May 13, 2025 14:22

lucas-zimerman added 2 commits May 13, 2025 15:19

add experimental support for log tracing

20cd6e9

project cleanup

b177094

lucas-zimerman added Blocked Feature and removed Blocked labels May 20, 2025

lucas-zimerman added 4 commits May 21, 2025 07:41

Merge branch 'v7' into lz/v7-test-logs

5d432d6

Merge branch 'v7' of https://github.com/getsentry/sentry-react-native …

7c24aa5

…into lz/v7-test-logs

enable android log

14ad53a

Merge branch 'lz/v7-test-logs' of https://github.com/getsentry/sentry…

cc52bf8

…-react-native into lz/v7-test-logs

lucas-zimerman added 2 commits May 22, 2025 15:39

use correct content type

a78e311

Merge branch 'v7' into lz/v7-test-logs

9eb1fb4

lucas-zimerman removed the Blocked label May 26, 2025

lucas-zimerman mentioned this pull request May 26, 2025

chore(deps-v7): update Javascript SDK to v9.22.0 #4860

Merged

10 tasks

lucas-zimerman added 3 commits May 26, 2025 17:05

Merge branch 'v7' of https://github.com/getsentry/sentry-react-native …

307ccd1

…into lz/v7-test-logs

fix lint

d83d2a2

Merge branch 'lz/v7-test-logs' of https://github.com/getsentry/sentry…

0f2f574

…-react-native into lz/v7-test-logs

lucas-zimerman commented May 27, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lucas-zimerman commented May 27, 2025

View reviewed changes

samples/react-native/src/App.tsx Outdated Show resolved Hide resolved

Update samples/react-native/src/App.tsx

c0c3818

lucas-zimerman changed the title ~~(WIP) Log Tracing~~ (feat-V7) Log Tracing May 27, 2025

lucas-zimerman added 9 commits May 27, 2025 11:06

merge v7 / fix yarn lock

310aeb0

fix parenthesis

03c3cfb

avoid var

600f436

add chcangelog

d59fce3

fix tests an add self hosted requirement

ab99989

actually mention 25.2.0

9cb856d

Update CHANGELOG.md

310b00b

Merge branch 'v7' into lz/v7-test-logs

0982fad

Merge branch 'v7' into lz/v7-test-logs

3ffd7ca

lucas-zimerman marked this pull request as ready for review May 28, 2025 10:28

lucas-zimerman requested review from krystofwoldrich and antonis as code owners May 28, 2025 10:28

Merge branch 'v7' into lz/v7-test-logs

c917647

antonis reviewed May 29, 2025

View reviewed changes

antonis approved these changes May 29, 2025

View reviewed changes

Uh oh!

(feat-V7) Log Tracing #4827

Are you sure you want to change the base?

(feat-V7) Log Tracing #4827

Uh oh!

Conversation

lucas-zimerman commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

Blocked by:

📜 Description

💡 Motivation and Context

💚 How did you test it?

Pii

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Previous results on branch: lz/v7-test-logs

Startup times

App size

Uh oh!

github-actions bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Previous results on branch: lz/v7-test-logs

Startup times

App size

Uh oh!

github-actions bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Previous results on branch: lz/v7-test-logs

Startup times

App size

Uh oh!

lucas-zimerman commented May 22, 2025

Uh oh!

lucas-zimerman commented May 26, 2025

Uh oh!

lucas-zimerman May 27, 2025

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman May 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: v7

Startup times

App size

Previous results on branch: lz/v7-test-logs

Startup times

App size

Uh oh!

lucas-zimerman May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucas-zimerman May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucas-zimerman commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonis May 29, 2025

Choose a reason for hiding this comment

lucas-zimerman commented May 13, 2025 •

edited

Loading

github-actions bot commented May 13, 2025 •

edited

Loading

github-actions bot commented May 13, 2025 •

edited

Loading

github-actions bot commented May 13, 2025 •

edited

Loading

github-actions bot commented May 27, 2025 •

edited

Loading

lucas-zimerman commented May 28, 2025 •

edited

Loading