Skip to content

feat(boto3): Support data_collection filtering for URL query params - #7290

Open
ericapisani wants to merge 1 commit into
py-2747-cohere-data-collectionfrom
py-2745-boto3-data-collection
Open

feat(boto3): Support data_collection filtering for URL query params#7290
ericapisani wants to merge 1 commit into
py-2747-cohere-data-collectionfrom
py-2745-boto3-data-collection

Conversation

@ericapisani

@ericapisani ericapisani commented Aug 28, 2026

Copy link
Copy Markdown
Member

Previously the boto3 integration only redacted URL query params and
fragments based on send_default_pii, always leaking the full query string
when PII collection was enabled. Now the data_collection experiment's
url_query_params allow/deny list is applied to the span-streaming span
attributes and to breadcrumbs, matching the behaviour already shipped for
httpx and pyreqwest.

url.full now includes the filtered query string and fragment, and
url.query / url.fragment are omitted rather than reported as empty
strings when the request URL has none.

The legacy (non span-streaming) span path is left as-is.

Fixes PY-2745
Fixes #7280

Previously the boto3 integration only redacted URL query params and
fragments based on send_default_pii, always leaking the full query string
when PII collection was enabled. Now the data_collection experiment's
url_query_params allow/deny list is applied to the span-streaming span
attributes and to breadcrumbs, matching the behaviour already shipped for
httpx and pyreqwest.

url.full now includes the filtered query string and fragment, and
url.query / url.fragment are omitted rather than reported as empty
strings when the request URL has none.

The legacy (non span-streaming) span path is left as-is.

Fixes PY-2745
Fixes #7280
@linear-code

linear-code Bot commented Aug 28, 2026

Copy link
Copy Markdown

PY-2745

@ericapisani
ericapisani marked this pull request as ready for review August 28, 2026 18:07
@ericapisani
ericapisani requested a review from a team as a code owner August 28, 2026 18:07
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

121163 passed | ⏭️ 6762 skipped | Total: 127925 | Pass Rate: 94.71% | Execution Time: 424m 12s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +2103
Passed Tests 📈 +2103
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 91.67%. Project has 2487 uncovered lines.
✅ Project coverage is 90.31%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/boto3.py 91.67% ⚠️ 2 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.29%    90.31%    +0.02%
==========================================
  Files          193       193         —
  Lines        25601     25678       +77
  Branches      9436      9466       +30
==========================================
+ Hits         23116     23191       +75
- Misses        2485      2487        +2
- Partials      1435      1444        +9

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update boto3 integration to support data collection

1 participant