Skip to content

fix(opentelemetry): Handle None span context#5968

Merged
alexander-alderman-webb merged 3 commits intowebb/anthropic/cifrom
webb/mypy
Apr 10, 2026
Merged

fix(opentelemetry): Handle None span context#5968
alexander-alderman-webb merged 3 commits intowebb/anthropic/cifrom
webb/mypy

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Apr 10, 2026

Description

Exit early if there is no span context, as there is no trace_id or span_id to create a Sentry span in this case.

The context of ReadableSpan is optional: https://github.com/open-telemetry/opentelemetry-python/blob/73d65fd2e90a2547c5c78eef1fdfcb21076a930d/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py#L420

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (ai) Redact base64 data URLs in image_url content blocks by ericapisani in #5953
  • (integrations) Instrument pyreqwest tracing by servusdei2018 in #5682

Bug Fixes 🐛

Anthropic

  • Stop setting transaction status when child span fails by alexander-alderman-webb in #5717
  • Only finish relevant spans in .create() patches by alexander-alderman-webb in #5716

Other

  • (opentelemetry) Handle None span context by alexander-alderman-webb in #5968
  • (wsgi) Respect HTTP_X_FORWARDED_PROTO in request.url construction by sl0thentr0py in #5963

Internal Changes 🔧

  • (anthropic) Separate sync and async .create() patches by alexander-alderman-webb in #5715
  • (openai) Split token counting by API for easier deprecation by ericapisani in #5930
  • (opentelemetry) Ignore mypy error by alexander-alderman-webb in #5927
  • Pin tokenizers version for anthropic tests on Python 3.8 by alexander-alderman-webb in #5967
  • Fix license metadata in setup.py by sl0thentr0py in #5934
  • Update validate-pr workflow by stephanie-anderson in #5931

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.60s

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 14845 uncovered lines.

Files with missing lines (1)
File Patch % Lines
span_processor.py 0.00% ⚠️ 205 Missing

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review April 10, 2026 08:39
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner April 10, 2026 08:39
@alexander-alderman-webb alexander-alderman-webb merged commit 1b07705 into webb/anthropic/ci Apr 10, 2026
152 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/mypy branch April 10, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants