-
Notifications
You must be signed in to change notification settings - Fork 572
fix(integrations): google-genai: reworked gen_ai.request.messages extraction from parameters
#5275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(integrations): google-genai: reworked gen_ai.request.messages extraction from parameters
#5275
Conversation
… if mime_type and file_uri are present (Cursor comment)
…i-report-image-inputs
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
| return { | ||
| "type": "blob", | ||
| "mime_type": mime_type, | ||
| "content": f"data:{mime_type};base64,{data_b64}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An analogous comment to https://github.com/getsentry/sentry-python/pull/5251/changes#r2689423926.
We should not encode something that is stripped later on, if encoding can raise an exception.
Description
Previously we only extracted only text parts were extracted. Now the full range of possibilities are covered.
Issues
Closes https://linear.app/getsentry/issue/TET-1638/redact-images-google-genai