Repository navigation
ref(integration): Only use string PATH_INFO as transaction to drop PHPStan baseline entry - #2364
Merged
Litarnus merged 2 commits intoNov 16, 2026
Merged
Conversation
…PStan baseline entry
Collaborator
|
Mago raised a point here, can you check that we don't introduce a mago failure by adding a redundant check |
…edundant-operation warning
Contributor
Author
|
Good catch, @Litarnus. The I changed it to |
Litarnus
marked this pull request as ready for review
November 16, 2026 13:19
Litarnus
approved these changes
Nov 16, 2026
Litarnus
deleted the
junior/phpstan-transaction-integration-path-info
branch
November 16, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes this entry from
phpstan-baseline.neon:TransactionIntegrationnow falls back to$_SERVER['PATH_INFO']only when it is a string, the same way it already checks thetransactionhint value. PHP SAPIs always setPATH_INFOas a string, so normal requests behave the same. If something puts a non-string value there, the event keeps anulltransaction instead of hitting aTypeErrorinside the event processor.via automation
sched_a59acc45df166a80a839d0b32321e740· Run IDsched_a59acc45df166a80a839d0b32321e740:1794733200000.--
View Session [Sentry]