Skip to content

ref(tracing): Document Span::setMetricsSummary tags type to drop PHPStan baseline entry - #2363

Merged
Litarnus merged 1 commit into
masterfrom
junior/phpstan-span-set-metrics-summary-tags
Nov 16, 2026
Merged

Litarnus merged 1 commit into
masterfrom
junior/phpstan-span-set-metrics-summary-tags

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Removes this entry from phpstan-baseline.neon:

Method Sentry\Tracing\Span::setMetricsSummary() has parameter $tags with no value type specified in iterable type array. (missingType.iterableValue, src/Tracing/Span.php)

This adds @param string[] $tags to the deprecated no-op Span::setMetricsSummary(). That's the type the method documented before the metrics API became a no-op.

It only changes a docblock on a method with an empty body, so there's no runtime or public API change.

via automation sched_a59acc45df166a80a839d0b32321e740 · Run ID sched_a59acc45df166a80a839d0b32321e740:1794733200000.

--

View Session [Sentry]

@Litarnus
Litarnus marked this pull request as ready for review November 16, 2026 13:14
@Litarnus
Litarnus requested review from a team and stayallive as code owners November 16, 2026 13:14
@Litarnus
Litarnus merged commit eec7e01 into master Nov 16, 2026
57 checks passed
@Litarnus
Litarnus deleted the junior/phpstan-span-set-metrics-summary-tags branch November 16, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant