perf: introduce source code caching to improve duplicate frames#2163
Open
Litarnus wants to merge 1 commit into
Open
perf: introduce source code caching to improve duplicate frames#2163Litarnus wants to merge 1 commit into
Litarnus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small caching layer while processing stack frames to prevent duplicate file reads.
This change benefits recursive functions as well as laravel stacktraces. Laravel middlewares are resolved through generic closures which will be invoked once per middleware and will yield the exact same stack frames.
Caching those means that we will have to read it only once and save n-1 reads where n is the number of total middlewares.
Uses more memory for a stacktrace with only distinct frames but uses less memory for duplicated frames since we are not re-creating data but instead they all reference the same array internally