Backport of explicit protocol set

[j03k64]

Backport of explicit protocol setting: https://github.com/ShootProof/sentry-php/commit/6ce65abab960ddbd7b22355afe3088261fab4775#diff-e2b9681244f52c28911e89834f05a2953654ccb96e1d353b42cae64a753bab63

[cleptric]

Did you accidentally open the PR against the wrong fork? 😄

[j03k64]

Yes! Sorry! Doing a quick bandaid until I can get through dependency hell.

[Jean85]

@cleptric isn't this a backport of #1542?
Are we sure that we don't need it in 4.x? Do we need to forward-port it?

[j03k64]

@cleptric isn't this a backport of #1542? Are we sure that we don't need it anyway?

I'd say that if a backport was desired, it should be a full backport (guzzle and curl) and not just the curl portion that we use. I got around the dependency issue and ended up upgrading to 3.22 instead of this route anyway.

[Jean85]

Sorry, my worded my reply poorly. I don't think we're interested in backporting the fix onto an old unsupported version. We may be interested in a forward port in 4.x though.

[stayallive]

No need, 4.x already has it:

sentry-php/src/HttpClient/HttpClient.php

Line 74 in 1988283

curl_setopt($curlHandle, \CURLOPT_HTTP_VERSION, \CURL_HTTP_VERSION_1_1);

[cleptric]

Just for completeness sake.

We could, in theory, bump to HTTP/2 anytime, the bug in cURL does not happen in our HTTP client.

The issue was that the Decoder Plugin sets a TE header with invalid values in an HTTP/2 context. https://github.com/php-http/client-common/blob/676f98fb3785d2c9e1b16aa24d9fcc39066f3f06/src/Plugin/DecoderPlugin.php#L54-L67

See php-http/client-common#230