feat: crashpad support for C++17 compilers. #1110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supervacuus
force-pushed
the
feat/crashpad_cxx17_support
branch
from
092d889 to
4759af7
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
+ Coverage 82.58% 82.64% +0.06%
==========================================
Files 53 53
Lines 7896 7896
Branches 1234 1234
==========================================
+ Hits 6521 6526 +5
+ Misses 1265 1259 -6
- Partials 110 111 +1 |
Great! Happy New Year, @JoshuaMoelans. I want to review the changes needed in the forks line-by-line with you before we merge anything. A considerable amount of C++17 and 20 specifics require changing, and I want to ensure these are clear. We also must find a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1041 by introducing a fork for the transitive
mini_chromiumdependency. For details: getsentry/crashpad#116.