-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Xbox Series X/S. #1100
base: master
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 82.57% 82.59% +0.02%
==========================================
Files 53 53
Lines 7889 7889
Branches 1232 1232
==========================================
+ Hits 6514 6516 +2
+ Misses 1263 1261 -2
Partials 112 112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (didn't inspect cmake files in detail, as discussed in DMs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All look good to me.
Any improvements i had already have pending reviews to be moved over to this repo after this merge has gone in.
Reminder that this is the public SDK so only changes that rely on public GDK or public samples repo can be added here. |
set(CMAKE_TRY_COMPILE_PLATFORM_VARIABLES XdkEditionTarget BUILD_USING_BWOI) | ||
|
||
#--- Windows SDK | ||
set(SDKVersion 10.0.19041.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the GDK documentation, Windows SDK version 10.0.22000+ is required as of October 2023 GDK: https://learn.microsoft.com/en-us/gaming/gdk/_content/gc/getstarted/overviews/sdk-and-tools#windows-software-development-kit-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a follow up change that will auto detect the latest GDK and Windows SDK versions. I believe its just pending the merge of this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more surprised this even builds with what should be the "wrong" version of the Windows SDK. Thanks for the heads up about the follow-up change!
4699d94
to
10c73c5
Compare
fixes #1068.