Try harder to generate a slug for a cron monitor #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -266,7 +266,7 @@ private function createCheckIn(string $slug, CheckInStatus $status, ?string $id | |||
| $options = SentrySdk::getCurrentHub()->getClient()->getOptions(); | |||
|
|
|||
| return new CheckIn( | |||
| $slug, | |||
| Str::limit($slug, 128, ''), | |||
There was a problem hiding this comment.
What about raising an exception here, if the $slug is > 128 characters and cut of the string only, if the slug is autogenerated from a class (in makeSlugForScheduled)?
There was a problem hiding this comment.
We could. But that would make the code a lot more complex (to keep track where the name came from). I'm not sure there is much benefit to this. Especially since there is a very high chance the truncated string is still unique enough unless you are actively trying to break this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from Laracon EU: We should have enough data to generate a slug for a scheduled job cron. So this PR tries a bit harder to generate something meaningful.
For job classes we reverse it to get the most interesting part of the name (the actual class name) in the front.
Also added a limit on our side to prevent jobs being not accepted (correctly) by sentry if the slug needs to be truncated. Current limit is 128.