Skip to content

feat(browser): Extract XHR request instrumentation into xhrTracingIntegration - #26261

Draft
logaretm wants to merge 1 commit into
awad/long-tasks-integrationfrom
awad/xhr-tracing-integration
Draft

feat(browser): Extract XHR request instrumentation into xhrTracingIntegration#26261
logaretm wants to merge 1 commit into
awad/long-tasks-integrationfrom
awad/xhr-tracing-integration

Conversation

@logaretm

@logaretm logaretm commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

XHR instrumentation was always bundled, even in fetch-only apps, fixed by moving it into xhrTracingIntegration, which browserTracingIntegration registers by default.

I added a test that it's registered unless traceXHR is off.

@logaretm
logaretm added this pull request to stack #26263 November 10, 2026 16:44
@github-actions

github-actions Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 2319534 (PR test merge using develop at f9eda3d)

Against: 9face8a (develop) · base run #65594

⚠️ Baseline mismatch: 4 develop commit(s) in the PR build are missing from the baseline. Their size changes also affect this comparison. Compare commits. Re-run once develop's baseline build for f9eda3d finishes.

Path Size % Change Change
@sentry/browser 29.92 kB - -
@sentry/browser - with treeshaking flags 28.08 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.97 kB - -
@sentry/browser (incl. Tracing) 52.48 kB +0.37% +189 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.49 kB +0.36% +185 B 🔺
@sentry/browser (incl. Tracing, Profiling) 55.38 kB +0.19% +104 B 🔺
@sentry/browser (incl. Tracing, Replay) 92.38 kB -0.35% -318 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.09 kB -0.35% -278 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 97.09 kB -0.36% -343 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 109.9 kB -0.48% -526 B 🔽
@sentry/browser (incl. Feedback) 47.52 kB - -
@sentry/browser (incl. sendFeedback) 35.02 kB - -
@sentry/browser (incl. FeedbackAsync) 40.13 kB - -
@sentry/browser (incl. Metrics) 31.48 kB - -
@sentry/browser (incl. Logs) 31.77 kB - -
@sentry/browser (incl. Metrics & Logs) 32.45 kB - -
@sentry/react 31.78 kB - -
@sentry/react (incl. Tracing) 54.89 kB +0.24% +129 B 🔺
@sentry/vue 38.33 kB - -
@sentry/vue (incl. Tracing) 55.5 kB +0.31% +168 B 🔺
@sentry/svelte 29.95 kB - -
@sentry/remix (Remix 3 client bundle) 57.97 kB +0.09% +50 B 🔺
CDN Bundle 31.72 kB - -
CDN Bundle (incl. Tracing) 53.01 kB +0.24% +122 B 🔺
CDN Bundle (incl. Logs, Metrics) 34.52 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.58 kB +0.34% +188 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 76 kB - -
CDN Bundle (incl. Tracing, Replay) 91.3 kB +0.15% +134 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.95 kB +0.25% +226 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 97.52 kB +0.23% +221 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 100.06 kB +0.18% +170 B 🔺
CDN Bundle - uncompressed 92.76 kB - -
CDN Bundle (incl. Tracing) - uncompressed 156.77 kB +0.49% +753 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 164.55 kB +0.46% +753 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 233.18 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 278.79 kB +0.28% +753 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 286.56 kB +0.27% +753 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 292.5 kB +0.26% +753 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 300.25 kB +0.26% +753 B 🔺
@sentry/nextjs (client) 57.92 kB +0.33% +187 B 🔺
@sentry/sveltekit (client) 53 kB +0.35% +182 B 🔺
@sentry/core/server 44.39 kB - -
@sentry/core/browser 14.02 kB - -
@sentry/node 157.65 kB +0.01% +14 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.31 kB - -
@sentry/node - without tracing 97.23 kB +0.02% +18 B 🔺
@sentry/node - without channel injection 137.97 kB +0.02% +20 B 🔺
@sentry/aws-serverless 106.08 kB +0.03% +23 B 🔺
@sentry/cloudflare (withSentry) - minified 203.81 kB - -
@sentry/cloudflare (withSentry) 506.45 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 225.49 kB - -
@sentry/browser (incl. Tracing Core) 44.45 kB added added

View base workflow run

@github-actions

github-actions Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 2 not successful, 24 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Failing after 52s Details
❌ CI: Optional E2E Tests / E2E nextjs-16-cacheComponents (cloudflare) Test (optional) Failing after 10m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 42s Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-cloudflare Test (optional) Successful in 35s Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) Successful in 58s Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 42s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 59s Details
✅ CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 36s Details

@logaretm
feat(browser): Extract XHR request instrumentation into `xhrTracingIn…
9eb974f 
…tegration`

`browserTracingIntegration` registers it by default, so nothing changes for its users. `browserTracingCoreIntegration` only instruments fetch, so fetch-only apps can leave XHR out of their bundle.
@logaretm
logaretm force-pushed the awad/xhr-tracing-integration branch from d2a1a95 to 9eb974f Compare November 10, 2026 21:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@logaretm