test(e2e): Add a cloudflare-flue end-to-end application - #24477
Open
RulaKhaled wants to merge 3 commits into
Open
RulaKhaled wants to merge 3 commits into
RulaKhaled wants to merge 3 commits into
Conversation
Contributor
size-limit report 📦
|
RulaKhaled
added this pull request to stack #24478
September 17, 2026 14:18
RulaKhaled
force-pushed
the
feat/flue-cloudflare-e2e
branch
from
September 18, 2026 07:46
59f88d8 to
1ce2d24
Compare
mydea
reviewed
Sep 18, 2026
| // | ||
| // There is deliberately no `instrument()` call in this app: registering the Flue instrumentation is | ||
| // what `@sentry/cloudflare/vite` does at build time, and these tests exist to prove it. | ||
| export const cloudflare = extend({ |
Member
There was a problem hiding this comment.
would this not work with the cloudflare auto-instrumentation (so just having a instrument.server.mjs file)?
Collaborator
Author
There was a problem hiding this comment.
no it doesn't, tried it, it just silently does nothing
auto instrumentation only picks that file up when wrangler has main set, which flue doesn't, flue generates both the worker entry and the DO class, so there's nothing for us to transform. extend({ wrap }) is basically the hook flue provides for this (we need it even with a manual instrument)
A `flue init` Cloudflare app with no `instrument()` call anywhere: registration comes from the build, so any `gen_ai` span here is itself proof the auto-wiring worked. Covers AI spans, tool-error capture, a manual span nesting under its tool, and an orchestrion `dataloader` span in the agent's trace. Secrets go through `.dev.vars` rather than `--var`: Flue resolves the provider key inside `pi-ai` at runtime, so unlike Mastra there is nothing for Vite to inline, and `vite preview` is what serves the worker with Flue's generated Durable Object config. `agents` is declared explicitly — Flue's generated worker entry imports it without declaring it, which only resolves under npm's hoisting, not pnpm. The agent and loader modules avoid TypeScript generics and return types because Flue's `'use agent'` scan parses every source file as plain JavaScript.
`vite preview` serves the worker that wrangler builds, which is the artifact the build-time registration this app exists to prove actually ships in. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`@flue/runtime` depends on `hono@^4.8.3`, so a `~4.7.0` pin here cannot share it — pnpm installs a second copy and the app's router runs on 4.7.11 while Flue runs 4.13.8. That older copy also carries five high-severity advisories, which fails dependency review. Widening the range collapses both copies onto one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
RulaKhaled
force-pushed
the
feat/flue-cloudflare-e2e
branch
from
September 18, 2026 08:56
7757e86 to
cafe644
Compare
RulaKhaled
changed the title
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cafe644. Configure here.
RulaKhaled
marked this pull request as ready for review
September 18, 2026 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24476 — review that first.
A
flue initCloudflare app with noinstrument()call anywhere: registration comes from the build, so anygen_aispan here is itself proof the auto-wiring worked. Covers AI spans, tool-error capture, a manual span nesting under its tool, and an orchestriondataloaderspan in the agent's trace.Secrets go through
.dev.varsrather than--varbecause Flue resolves the provider key insidepi-aiat runtime, leaving nothing for Vite to inline, andvite previewis what serves the worker with Flue's generated Durable Object config.Two Flue constraints the app works around, both commented in place:
agentsis imported by Flue's generated worker entry without being declared, so it only resolves under npm's hoisting and needs declaring for pnpm; and the'use agent'scan parses every source file as plain JavaScript, so generics and return types fail the build.Worth a docs note: the Sentry wrapper has to be re-exported as
cloudflarefrom the agent module. Defining it elsewhere leaves the Durable Object unwrapped — the agent runs, turns settle, and nothing is traced.