fix(wasm): Match engine-named wasm frames to the single buffer module - #23662
Draft
andreiborza wants to merge 1 commit into
Draft
fix(wasm): Match engine-named wasm frames to the single buffer module#23662andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/wasm-firefox-fallback
branch
from
August 27, 2026 12:19
cf3c40e to
3eb5ff5
Compare
andreiborza
force-pushed
the
ab/wasm-firefox-fallback
branch
from
August 27, 2026 14:01
3eb5ff5 to
38529d5
Compare
andreiborza
changed the title
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/wasm-firefox-fallback
branch
from
August 28, 2026 09:05
38529d5 to
ae9e41a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae9e41a. Configure here.
| mainImages.forEach((image, i) => collect(image, i)); | ||
| workerImages.forEach((image, i) => collect(image, mainImages.length + i)); | ||
| return buildIds.size === 1 ? index : -1; | ||
| } |
There was a problem hiding this comment.
Fallback mis-attributes overwritten modules
Low Severity
The single-buffer fallback treats the registry as a complete set of buffer-compiled modules, but unnamed modules at or below V8's hashing cutoff all register under the same placeholder code_file (wasm://wasm/unknown), so a later compile replaces an earlier one. getSingleBufferImageIndex then sees one image and attributes every unmatched wasm:// frame to it, including frames from the overwritten module.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ae9e41a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Frames of buffer-compiled modules can carry a name the SDK cannot predict: Firefox derives it from the compile call site, and V8 hashes the content of modules at or below 16383 bytes. Such frames now resolve to the registered module when exactly one distinct module was compiled from raw bytes.
Why
Without this, non-streaming symbolication misses Firefox entirely and small modules on V8.
Related: #19564