fix(core): Replace regex with string check in stack parser to prevent main thread blocking#20089
Draft
fix(core): Replace regex with string check in stack parser to prevent main thread blocking#20089
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Other
Bug Fixes 🐛
Internal Changes 🔧Core
Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stack parser used the regex
/\S*Error: / to skip error description lines (e.g. "TypeError: foo")when parsing stack traces. The\S*quantifier causes O(n²) backtracking on long lines without whitespace, which are common in minified bundle stack traces.In apps using
thirdPartyErrorFilterIntegration, the stack parser is invoked on every_sentryModuleMetadataentry on the first error event. In large Next.js apps with many bundled chunks, this caused 1s+ main thread blocking.Replacing
.match(/\S*Error: /)with.includes('Error: ')which is O(n) and semantically equivalent — the\S*prefix could match zero characters, so it never affected which lines were matched.Fixes #20052