-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Remove tracing from generation function template #18733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(nextjs): Remove tracing from generation function template #18733
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
…tionfunctionwithsentry
| normalizedRequest: { | ||
| headers: headersDict, | ||
| } satisfies RequestEventData, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Navigation errors incorrectly captured when no span exists
High Severity
The shouldCapture variable defaults to true, but the logic that sets it to false for not-found and redirect navigation errors is nested inside if (span). When getActiveSpan() returns undefined (no active span), the navigation error checks are skipped entirely, causing captureException to be called for these expected navigation behaviors. This results in erroneous error reports to Sentry for redirects and 404s that should be silently ignored.
logaretm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
closes #18731