Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Jan 8, 2026

closes #18731

@chargome chargome self-assigned this Jan 8, 2026
@linear
Copy link

linear bot commented Jan 8, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,952 - 9,090 -2%
GET With Sentry 1,703 19% 1,711 -0%
GET With Sentry (error only) 6,070 68% 6,084 -0%
POST Baseline 1,168 - 1,181 -1%
POST With Sentry 581 50% 586 -1%
POST With Sentry (error only) 1,043 89% 1,038 +0%
MYSQL Baseline 3,270 - 3,296 -1%
MYSQL With Sentry 489 15% 459 +7%
MYSQL With Sentry (error only) 2,644 81% 2,680 -1%

View base workflow run

@chargome chargome requested a review from logaretm January 9, 2026 18:51
@chargome chargome marked this pull request as ready for review January 9, 2026 18:51
normalizedRequest: {
headers: headersDict,
} satisfies RequestEventData,
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation errors incorrectly captured when no span exists

High Severity

The shouldCapture variable defaults to true, but the logic that sets it to false for not-found and redirect navigation errors is nested inside if (span). When getActiveSpan() returns undefined (no active span), the navigation error checks are skipped entirely, causing captureException to be called for these expected navigation behaviors. This results in erroneous error reports to Sentry for redirects and 404s that should be silently ignored.

Fix in Cursor Fix in Web

Copy link
Collaborator

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove tracing from wrapGenerationFunctionWithSentry

3 participants