feat(replay): ignore background-image when blockAllMedia is enabled
#18019
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Pass `ignoreCSSAttributes` with `background-imgae` to ignore background images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was expanded in [this PR](getsentry/rrweb#252) so that it also works for inline styles.
billyvg
force-pushed
the
billy/feat-replay-ignore-background-css-inline
branch
from
83a5467 to
a6b7d3d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| this._recordingOptions.blockSelector = !this._recordingOptions.blockSelector | ||
| ? MEDIA_SELECTORS | ||
| : `${this._recordingOptions.blockSelector},${MEDIA_SELECTORS}`; | ||
| this._recordingOptions.ignoreCSSAttributes = new Set(['background-image']); |
There was a problem hiding this comment.
Bug: Media Block Overwrites CSS Ignore Settings
When blockAllMedia is enabled, this._recordingOptions.ignoreCSSAttributes is unconditionally overwritten with a new Set containing only 'background-image'. This causes any previously configured ignored CSS attributes to be lost, unlike the merging behavior for blockSelector.
There was a problem hiding this comment.
We don't publicly expose ignoreCSSAttributes so we won't be overwriting anything
|
@sentry review |
![sentry-io[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| : `${this._recordingOptions.blockSelector},${MEDIA_SELECTORS}`; | ||
| this._recordingOptions.ignoreCSSAttributes = new Set(['background-image']); |
There was a problem hiding this comment.
The ignoreCSSAttributes is unconditionally set here, which will override any user-provided configuration. Consider checking if it's already set before assigning it, or merging with existing values if the property supports it. This ensures that user-provided configurations are respected and not silently overwritten.
Severity: MEDIUM
🤖 Prompt for AI Agent
Fix this code. In packages/replay-internal/src/integration.ts#L189-L190: The
`ignoreCSSAttributes` is unconditionally set here, which will override any user-provided
configuration. Consider checking if it's already set before assigning it, or merging
with existing values if the property supports it. This ensures that user-provided
configurations are respected and not silently overwritten.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
@sentry can you check that we allow the user to provide ignoreCSSAttributes?
1 participant
Pass
ignoreCSSAttributeswithbackground-imgaeto ignore background images whenblockAllMediais enabled.ignoreCSSAttributeswas expanded in this PR so that it also works for inline styles.