Skip to content

feat: Upgrade OTEL deps #15472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat: Upgrade OTEL deps #15472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec496af
feat: Upgrade OTEL deps
AbhiPrasad Feb 24, 2025
18b33cb
Merge branch 'develop' into abhi-upgrade-otel-feb-2025
AbhiPrasad Feb 24, 2025
f8394ae
add deprecation warning for fastify
AbhiPrasad Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/aws-serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/instrumentation": "^0.57.1",
"@opentelemetry/instrumentation-aws-lambda": "0.50.2",
"@opentelemetry/instrumentation-aws-sdk": "0.49.0",
"@opentelemetry/instrumentation": "^0.57.2",
"@opentelemetry/instrumentation-aws-lambda": "0.50.3",
"@opentelemetry/instrumentation-aws-sdk": "0.49.1",
"@sentry/core": "9.1.0",
"@sentry/node": "9.1.0",
"@types/aws-lambda": "^8.10.62"
Expand Down
6 changes: 3 additions & 3 deletions packages/nestjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
"dependencies": {
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/core": "^1.30.1",
"@opentelemetry/instrumentation": "0.57.1",
"@opentelemetry/instrumentation-nestjs-core": "0.44.0",
"@opentelemetry/semantic-conventions": "^1.27.0",
"@opentelemetry/instrumentation": "0.57.2",
"@opentelemetry/instrumentation-nestjs-core": "0.44.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually not using this package in the Nest.js package. I think it's just there so we don't forget about upgrading it until this PR is merged.

For the time being, we have inlined the instrumentation in this PR.

Basically, we only changed this line: const supportedVersions = ['>=4.0.0 <12'];

But I'm not sure if it's worth it to update the inlined instrumentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it upgraded so that all the underlying deps have the same versions.

"@opentelemetry/semantic-conventions": "^1.30.0",
"@sentry/core": "9.1.0",
"@sentry/node": "9.1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/semantic-conventions": "^1.28.0",
"@opentelemetry/semantic-conventions": "^1.30.0",
"@rollup/plugin-commonjs": "28.0.1",
"@sentry-internal/browser-utils": "9.1.0",
"@sentry/core": "9.1.0",
Expand Down
52 changes: 26 additions & 26 deletions packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,37 +68,37 @@
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/context-async-hooks": "^1.30.1",
"@opentelemetry/core": "^1.30.1",
"@opentelemetry/instrumentation": "^0.57.1",
"@opentelemetry/instrumentation-amqplib": "^0.46.0",
"@opentelemetry/instrumentation-connect": "0.43.0",
"@opentelemetry/instrumentation-dataloader": "0.16.0",
"@opentelemetry/instrumentation-express": "0.47.0",
"@opentelemetry/instrumentation-fastify": "0.44.1",
"@opentelemetry/instrumentation-fs": "0.19.0",
"@opentelemetry/instrumentation-generic-pool": "0.43.0",
"@opentelemetry/instrumentation-graphql": "0.47.0",
"@opentelemetry/instrumentation-hapi": "0.45.1",
"@opentelemetry/instrumentation-http": "0.57.1",
"@opentelemetry/instrumentation-ioredis": "0.47.0",
"@opentelemetry/instrumentation-kafkajs": "0.7.0",
"@opentelemetry/instrumentation-knex": "0.44.0",
"@opentelemetry/instrumentation-koa": "0.47.0",
"@opentelemetry/instrumentation-lru-memoizer": "0.44.0",
"@opentelemetry/instrumentation-mongodb": "0.51.0",
"@opentelemetry/instrumentation-mongoose": "0.46.0",
"@opentelemetry/instrumentation-mysql": "0.45.0",
"@opentelemetry/instrumentation-mysql2": "0.45.0",
"@opentelemetry/instrumentation-pg": "0.51.0",
"@opentelemetry/instrumentation-redis-4": "0.46.0",
"@opentelemetry/instrumentation-tedious": "0.18.0",
"@opentelemetry/instrumentation-undici": "0.10.0",
"@opentelemetry/instrumentation": "^0.57.2",
"@opentelemetry/instrumentation-amqplib": "^0.46.1",
"@opentelemetry/instrumentation-connect": "0.43.1",
"@opentelemetry/instrumentation-dataloader": "0.16.1",
"@opentelemetry/instrumentation-express": "0.47.1",
"@opentelemetry/instrumentation-fastify": "0.44.2",
"@opentelemetry/instrumentation-fs": "0.19.1",
"@opentelemetry/instrumentation-generic-pool": "0.43.1",
"@opentelemetry/instrumentation-graphql": "0.47.1",
"@opentelemetry/instrumentation-hapi": "0.45.2",
"@opentelemetry/instrumentation-http": "0.57.2",
"@opentelemetry/instrumentation-ioredis": "0.47.1",
"@opentelemetry/instrumentation-kafkajs": "0.7.1",
"@opentelemetry/instrumentation-knex": "0.44.1",
"@opentelemetry/instrumentation-koa": "0.47.1",
"@opentelemetry/instrumentation-lru-memoizer": "0.44.1",
"@opentelemetry/instrumentation-mongodb": "0.52.0",
"@opentelemetry/instrumentation-mongoose": "0.46.1",
"@opentelemetry/instrumentation-mysql": "0.45.1",
"@opentelemetry/instrumentation-mysql2": "0.45.2",
"@opentelemetry/instrumentation-pg": "0.51.1",
"@opentelemetry/instrumentation-redis-4": "0.46.1",
"@opentelemetry/instrumentation-tedious": "0.18.1",
"@opentelemetry/instrumentation-undici": "0.10.1",
"@opentelemetry/resources": "^1.30.1",
"@opentelemetry/sdk-trace-base": "^1.30.1",
"@opentelemetry/semantic-conventions": "^1.28.0",
"@opentelemetry/semantic-conventions": "^1.30.0",
"@prisma/instrumentation": "6.2.1",
"@sentry/core": "9.1.0",
"@sentry/opentelemetry": "9.1.0",
"import-in-the-middle": "^1.12.0"
"import-in-the-middle": "^1.13.0"
},
"devDependencies": {
"@types/node": "^18.19.1"
Expand Down
1 change: 1 addition & 0 deletions packages/node/src/integrations/tracing/fastify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const INTEGRATION_NAME = 'Fastify';
export const instrumentFastify = generateInstrumentOnce(
INTEGRATION_NAME,
() =>
// eslint-disable-next-line deprecation/deprecation
new FastifyInstrumentation({
requestHook(span) {
addFastifySpanAttributes(span);
Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/context-async-hooks": "^1.30.1",
"@opentelemetry/core": "^1.30.1",
"@opentelemetry/instrumentation": "^0.57.1",
"@opentelemetry/instrumentation": "^0.57.2",
"@opentelemetry/sdk-trace-base": "^1.30.1",
"@opentelemetry/semantic-conventions": "^1.28.0"
"@opentelemetry/semantic-conventions": "^1.30.0"
},
"scripts": {
"build": "run-p build:transpile build:types",
Expand Down
Loading
Loading