Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clean up migration guide for v9 #15287

Merged
merged 13 commits into from
Feb 5, 2025
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 4, 2025

Gives the migration guide a pass.

General things I did:

  • Remove duplicate information
  • Remove deprecations section
  • Make language more instructive and less fluffy
  • Removed information that was redundant
  • Make sure it is more mentally parseable/scannable by putting actual APIs in the first few words of each sentence.

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, overall great changes!

docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
@lforst lforst requested review from Lms24 and mydea February 5, 2025 10:31
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, ready much better now!

@lforst
Copy link
Member Author

lforst commented Feb 5, 2025

I am merging to unblock myself. We can iterate more still!

@lforst lforst merged commit 0a74795 into develop Feb 5, 2025
141 of 143 checks passed
@lforst lforst deleted the lforst-migration-guide-impro branch February 5, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants