Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Only run flaky test detection for chromium #15264

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 3, 2025

This streamlines this a bit and should be good enough here.

This streamlines this a bit and should be good enough here.
@mydea mydea requested review from Lms24 and s1gr1d February 3, 2025 12:51
@mydea mydea self-assigned this Feb 3, 2025
@mydea mydea enabled auto-merge (squash) February 3, 2025 15:33
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna block this but afaik this job isn't blocking a merge and running the flake detector for other browser potentially catches more flakes 🤔 No strong opinions, feel free to merge anyway but maybe something to consider

@mydea mydea merged commit e8c0260 into develop Feb 3, 2025
55 checks passed
@mydea mydea deleted the fn/flaky-test-detection-chromium-only branch February 3, 2025 16:32
@mydea
Copy link
Member Author

mydea commented Feb 3, 2025

Not gonna block this but afaik this job isn't blocking a merge and running the flake detector for other browser potentially catches more flakes 🤔 No strong opinions, feel free to merge anyway but maybe something to consider

It just takes way longer and I've never seen this catch a bug so far 🤔 we can always add it back if we ever find a flake that only happens on webkit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants