Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add silent, errorHandler, release to SourceMapsOptions #15246

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

maxmaxme
Copy link
Contributor

This pull request includes changes to enhance the configuration options for managing Sentry source maps in a Nuxt.js project. The most important changes include adding new options to suppress logs, handle errors during release creation, and manage Sentry releases.

Enhancements to Sentry source maps configuration:

  • packages/nuxt/src/common/types.ts: Added silent, errorHandler, and release options to the SourceMapsOptions type to provide more control over logging, error handling, and release management.
  • packages/nuxt/src/vite/sourceMaps.ts: Updated the getPluginOptions function to include the new silent, errorHandler, and release options, allowing them to be used during the source maps upload process.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maxmaxme thanks for opening this PR! I'll let @s1gr1d give her final 👍 before merging this in. Just had one request.

We'll get to this next week. In the meantime, you can use unstable_sentryBundlerPluginOptions to pass these properties as well.

packages/nuxt/src/common/types.ts Outdated Show resolved Hide resolved
@mydea mydea requested a review from s1gr1d January 31, 2025 11:49
@s1gr1d s1gr1d merged commit fa8c180 into getsentry:develop Feb 3, 2025
130 checks passed
mydea added a commit that referenced this pull request Feb 3, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15246

---------

Co-authored-by: s1gr1d <[email protected]>
Co-authored-by: Francesco Gringl-Novy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants