fix(react): From location can be undefined in Tanstack Router Instrumentation #15235
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a big bug in TanStack Router getting fixed, this needs an optional chain to not die.
TkDodo
approved these changes
Jan 30, 2025
Lms24
changed the title
Lms24
added a commit
that referenced
this pull request
Jan 31, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15235 --------- Co-authored-by: Lms24 <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
mydea
added a commit
that referenced
this pull request
Jan 31, 2025
We adapted this here but did not adapt the types: #15235
Lms24
added a commit
that referenced
this pull request
Jan 31, 2025
…rumentation (#15237) backport of #15235 and #15241 --------- Co-authored-by: Tanner Linsley <[email protected]> Co-authored-by: Francesco Novy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15234
Due to a big bug in TanStack Router getting fixed, this needs an optional chain to not die.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).