fix(node): Ensure httpIntegration propagates traces
#15233
Merged
+266
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
reviewed
Jan 31, 2025
packages/node/src/integrations/http/SentryHttpInstrumentation.ts
Outdated
Show resolved
Hide resolved
| // If the core UndiciInstrumentation is registered, it will already have set the headers | ||
| // We do not want to add any then | ||
| if (!headers[k]) { | ||
| headers[k] = v; |
There was a problem hiding this comment.
m: This works for sentry-trace but since baggage is standardized, other libraries or users might add their own entries. Which means we need to check for sentry- values in existing headers.
There was a problem hiding this comment.
I updated it to merge baggages together!
We used to rely on the existence of another `httpIntegration`
Co-authored-by: Lukas Stracke <[email protected]>
mydea
force-pushed
the
fn/node-http-inject
branch
from
3a5fb3a to
2c8d0d6
Compare
Lms24
approved these changes
Jan 31, 2025
mydea
force-pushed
the
fn/node-http-inject
branch
from
dff0b91 to
81090de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15231, I noticed that we today would not propagate traces in outgoing http requests if:
httpIntegration({ spans: false })HttpInstrumentationAdmittedly and edge case. More importantly, though, by actually adding distributed tracing information here, we are unblocked from potentially stopping to ship the http-instrumentation to users that do not need spans (and/or have a custom otel setup).