Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(v8/browser): Add protocol attributes to resource spans #15224

Merged
merged 2 commits into from
Jan 30, 2025
Merged

ref(v8/browser): Add protocol attributes to resource spans #15224

merged 2 commits into from
Jan 30, 2025
+222 −99

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 29, 2025

Backport of #15161

@Lms24 Lms24 requested review from a team, stephanie-anderson, andreiborza and AbhiPrasad and removed request for a team and stephanie-anderson January 29, 2025 14:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.3 KB - -
@sentry/browser - with treeshaking flags 23.17 KB - -
@sentry/browser (incl. Tracing) 35.9 KB +0.11% +37 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.27 KB +0.08% +56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.71 KB +0.06% +35 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.57 KB +0.07% +49 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.5 KB +0.07% +55 B 🔺
@sentry/browser (incl. Feedback) 39.51 KB - -
@sentry/browser (incl. sendFeedback) 27.91 KB - -
@sentry/browser (incl. FeedbackAsync) 32.71 KB - -
@sentry/react 25.98 KB - -
@sentry/react (incl. Tracing) 38.71 KB +0.08% +29 B 🔺
@sentry/vue 27.58 KB - -
@sentry/vue (incl. Tracing) 37.75 KB +0.09% +31 B 🔺
@sentry/svelte 23.46 KB - -
CDN Bundle 24.49 KB - -
CDN Bundle (incl. Tracing) 37.6 KB +0.08% +28 B 🔺
CDN Bundle (incl. Tracing, Replay) 72.9 KB +0.07% +52 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 78.23 KB +0.03% +23 B 🔺
CDN Bundle - uncompressed 71.92 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.52 KB +0.1% +112 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.78 KB +0.05% +112 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.88 KB +0.05% +112 B 🔺
@sentry/nextjs (client) 38.96 KB +0.08% +31 B 🔺
@sentry/sveltekit (client) 36.4 KB +0.1% +35 B 🔺
@sentry/node 162.84 KB - -
@sentry/node - without tracing 99.15 KB - -
@sentry/aws-serverless 126.67 KB - -

View base workflow run

Zen-cronic and others added 2 commits January 30, 2025 09:38
@Zen-cronic @Lms24
ref(v8/browser): Add protocol attributes to resource spans
065adeb 
- Relocated `extractNetworkProtocol` util and its unit test to `browser-utils`.
- Modified `browserMetrics` test to assert the new metadata.
- Added integration test

---------

Signed-off-by: Kaung Zin Hein <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
@Lms24
attribution
fcd3bba
@Lms24 Lms24 force-pushed the lms/v8-protocol-attributes-on-resource-spans branch from 4662977 to fcd3bba Compare January 30, 2025 08:38
@Lms24 Lms24 mentioned this pull request Jan 30, 2025
Merged
@Lms24 Lms24 enabled auto-merge (squash) January 30, 2025 08:43
@Lms24 Lms24 merged commit 6152ef5 into v8 Jan 30, 2025
126 checks passed
@Lms24 Lms24 deleted the lms/v8-protocol-attributes-on-resource-spans branch January 30, 2025 08:52
This was referenced Jan 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@andreiborza andreiborza Awaiting requested review from andreiborza andreiborza was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lms24 @AbhiPrasad @Zen-cronic