Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(v8/core): Don't set this.name to new.target.prototype.constructor.name #15222

Merged
merged 2 commits into from
Jan 30, 2025
Merged

ref(v8/core): Don't set this.name to new.target.prototype.constructor.name #15222

merged 2 commits into from
Jan 30, 2025
+3 −12

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 29, 2025

Backport, fixes #15214

@mydea mydea requested a review from lforst January 29, 2025 13:52
@mydea mydea self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.3 KB -0.11% -24 B 🔽
@sentry/browser - with treeshaking flags 23.17 KB -0.11% -25 B 🔽
@sentry/browser (incl. Tracing) 35.86 KB -0.06% -21 B 🔽
@sentry/browser (incl. Tracing, Replay) 73.21 KB -0.03% -18 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.68 KB -0.03% -20 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.52 KB -0.03% -19 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.45 KB -0.03% -22 B 🔽
@sentry/browser (incl. Feedback) 39.51 KB -0.06% -22 B 🔽
@sentry/browser (incl. sendFeedback) 27.91 KB -0.12% -32 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.71 KB -0.07% -21 B 🔽
@sentry/react 25.98 KB -0.09% -23 B 🔽
@sentry/react (incl. Tracing) 38.68 KB -0.07% -27 B 🔽
@sentry/vue 27.58 KB -0.08% -21 B 🔽
@sentry/vue (incl. Tracing) 37.72 KB -0.06% -22 B 🔽
@sentry/svelte 23.46 KB -0.1% -23 B 🔽
CDN Bundle 24.49 KB -0.12% -29 B 🔽
CDN Bundle (incl. Tracing) 37.57 KB -0.06% -21 B 🔽
CDN Bundle (incl. Tracing, Replay) 72.85 KB -0.03% -22 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 78.21 KB -0.03% -24 B 🔽
CDN Bundle - uncompressed 71.92 KB -0.14% -97 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 111.41 KB -0.09% -97 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.67 KB -0.05% -97 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.77 KB -0.04% -97 B 🔽
@sentry/nextjs (client) 38.93 KB -0.07% -25 B 🔽
@sentry/sveltekit (client) 36.37 KB -0.06% -19 B 🔽
@sentry/node 162.84 KB -0.02% -32 B 🔽
@sentry/node - without tracing 99.15 KB -0.04% -34 B 🔽
@sentry/aws-serverless 126.67 KB -0.03% -26 B 🔽

View base workflow run

@mydea
ref(v8/core): Don't set this.name to `new.target.prototype.construc…
d83d338 
…tor.name` on `SentryError` class

We did some funky stuff in there that does not seem necessary and can
even lead to issues.

Fixes #15214.
@mydea mydea force-pushed the fn/backport-sentryError branch from 46a82d1 to d83d338 Compare January 29, 2025 15:27
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
700 1 699 305
View the top 1 failed tests by shortest run time 
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time 
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@mydea mydea merged commit a0470da into v8 Jan 30, 2025
159 checks passed
@mydea mydea deleted the fn/backport-sentryError branch January 30, 2025 07:59
This was referenced Jan 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @lforst