fix(core): Ensure debugIds are applied to all exceptions in an event#14881
Merged
fix(core): Ensure debugIds are applied to all exceptions in an event#14881
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
Wait, how does this increase bundle size? 😢 Update: Looks like we accidentally still polyfill |
8 tasks
timfish
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #14841, I noticed that we had some brittle non-null assertions in our
applyDebugIdsfunction which would cause the debug id application logic to terminate early, in case we'd encounter anevent.exception.valuesitem without a stack trace. The added regression test illustrates the scenario in which debug ids would not have been applied to the second exception prior to this fix.The nice thing about this fix is that it should even further decrease bundle size than the try/catch logic we had before because we can now use optional chaining in v9.
(I'll probably open another PR for the same problem inAdded to this PR as it really belonged together to get debugIds working in this scenario.applyDebugMeta)