Merge branch 'develop' into ci-yarn-deduplicate

getsentry · Feb 3, 2025 · 887c855 · 887c855
2 parents c8a3415 + e8c0260
commit 887c855
Show file tree

Hide file tree

Showing 55 changed files with 204 additions and 144 deletions.
diff --git a/.github/workflows/flaky-test-detector.yml b/.github/workflows/flaky-test-detector.yml
@@ -51,6 +51,8 @@ jobs:
 
       - name: Install Playwright
         uses: ./.github/actions/install-playwright
+        with:
+          browsers: 'chromium'
 
       - name: Determine changed tests
         uses: dorny/[email protected]

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,7 +10,15 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
-Work in this release was contributed by @tjhiggins, @chris-basebone, @GrizliK1988, @davidturissini, @nwalters512, @aloisklink, @arturovt, @benjick, @maximepvrt, @mstrokin, @kunal-511, @jahands, @jrandolf, @tannerlinsley, @Zen-cronic and @nathankleyn. Thank you for your contributions!
+Work in this release was contributed by @tjhiggins, @chris-basebone, @GrizliK1988, @davidturissini, @nwalters512, @aloisklink, @arturovt, @benjick, @maximepvrt, @mstrokin, @kunal-511, @jahands, @jrandolf, @tannerlinsley, @Zen-cronic, @maxmaxme and @nathankleyn. Thank you for your contributions!
+
+## 9.0.0-alpha.1
+
+This is an alpha release of the upcoming major release of version 9.
+This release does not yet entail a comprehensive changelog as version 9 is not yet stable.
+
+For this release's iteration of the migration guide, see the [Migration Guide as per `9.0.0-alpha.1`](https://github.com/getsentry/sentry-javascript/blob/e4333e5ce2d65be319ee6a5a5976f7c93983a417/docs/migration/v8-to-v9.md).
+Please note that the migration guide is work in progress and subject to change.
 
 ## 9.0.0-alpha.0
 

diff --git a/dev-packages/browser-integration-tests/package.json b/dev-packages/browser-integration-tests/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "main": "index.js",
   "license": "MIT",
   "engines": {
@@ -42,7 +42,7 @@
     "@babel/preset-typescript": "^7.16.7",
     "@playwright/test": "~1.50.0",
     "@sentry-internal/rrweb": "2.31.0",
-    "@sentry/browser": "9.0.0-alpha.0",
+    "@sentry/browser": "9.0.0-alpha.1",
     "axios": "1.7.7",
     "babel-loader": "^8.2.2",
     "fflate": "0.8.2",

diff --git a/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts b/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts
@@ -46,7 +46,9 @@ ${changedPaths.join('\n')}
   try {
     await new Promise<void>((resolve, reject) => {
       const cp = childProcess.spawn(
-        `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
+        `npx playwright test ${
+          testPaths.length ? testPaths.join(' ') : './suites'
+        } --repeat-each ${repeatEachCount} --project=chromium`,
         { shell: true, cwd, stdio: 'inherit' },
       );
 

diff --git a/dev-packages/bundle-analyzer-scenarios/package.json b/dev-packages/bundle-analyzer-scenarios/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/bundle-analyzer-scenarios",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Scenarios to test bundle analysis with",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",

diff --git a/dev-packages/clear-cache-gh-action/package.json b/dev-packages/clear-cache-gh-action/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@sentry-internal/clear-cache-gh-action",
   "description": "An internal Github Action to clear GitHub caches.",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "license": "MIT",
   "engines": {
     "node": ">=18"

diff --git a/dev-packages/e2e-tests/package.json b/dev-packages/e2e-tests/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/e2e-tests",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "license": "MIT",
   "private": true,
   "scripts": {

diff --git a/dev-packages/external-contributor-gh-action/package.json b/dev-packages/external-contributor-gh-action/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@sentry-internal/external-contributor-gh-action",
   "description": "An internal Github Action to add external contributors to the CHANGELOG.md file.",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "license": "MIT",
   "engines": {
     "node": ">=18"

diff --git a/dev-packages/node-integration-tests/package.json b/dev-packages/node-integration-tests/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/node-integration-tests",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "license": "MIT",
   "engines": {
     "node": ">=18"
@@ -31,9 +31,9 @@
     "@nestjs/common": "10.4.6",
     "@nestjs/core": "10.4.6",
     "@nestjs/platform-express": "10.4.6",
-    "@sentry/aws-serverless": "9.0.0-alpha.0",
-    "@sentry/core": "9.0.0-alpha.0",
-    "@sentry/node": "9.0.0-alpha.0",
+    "@sentry/aws-serverless": "9.0.0-alpha.1",
+    "@sentry/core": "9.0.0-alpha.1",
+    "@sentry/node": "9.0.0-alpha.1",
     "@types/mongodb": "^3.6.20",
     "@types/mysql": "^2.15.21",
     "@types/pg": "^8.6.5",

diff --git a/dev-packages/rollup-utils/package.json b/dev-packages/rollup-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/rollup-utils",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Rollup utilities used at Sentry for the Sentry JavaScript SDK",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/rollup-utils",

diff --git a/dev-packages/size-limit-gh-action/package.json b/dev-packages/size-limit-gh-action/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@sentry-internal/size-limit-gh-action",
   "description": "An internal Github Action to compare the current size of a PR against the one on develop.",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "license": "MIT",
   "engines": {
     "node": ">=18"

diff --git a/dev-packages/test-utils/package.json b/dev-packages/test-utils/package.json
@@ -1,6 +1,6 @@
 {
   "private": true,
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "name": "@sentry-internal/test-utils",
   "author": "Sentry",
   "license": "MIT",
@@ -45,7 +45,7 @@
   },
   "devDependencies": {
     "@playwright/test": "~1.50.0",
-    "@sentry/core": "9.0.0-alpha.0"
+    "@sentry/core": "9.0.0-alpha.1"
   },
   "volta": {
     "extends": "../../package.json"

diff --git a/docs/migration/v8-to-v9.md b/docs/migration/v8-to-v9.md
@@ -361,7 +361,7 @@ This should not affect most users unless you relied on passing things with a sim
 - The `Request` type has been removed. Use `RequestEventData` type instead.
 - The `IntegrationClass` type is no longer exported - it was not used anymore. Instead, use `Integration` or `IntegrationFn`.
 - The `samplingContext.request` attribute in the `tracesSampler` has been removed. Use `samplingContext.normalizedRequest` instead. Note that the type of `normalizedRequest` differs from `request`.
-- The `samplingContext.transactionContext` object in the `tracesSampler` has been removed. All object attributes are available in the top-level of `samplingContext`.
+- The `samplingContext.transactionContext` object in the `tracesSampler` and `profilesSampler` has been removed. All object attributes are available in the top-level of `samplingContext`.
 - `Client` now always expects the `BaseClient` class - there is no more abstract `Client` that can be implemented! Any `Client` class has to extend from `BaseClient`.
 - `ReportDialogOptions` now extends `Record<string, unknown>` instead of `Record<string, any>` - this should not affect most users.
 - The `RequestDataIntegrationOptions` type has been removed. There is no replacement.

diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "npmClient": "yarn"
 }
diff --git a/packages/angular/package.json b/packages/angular/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/angular",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for Angular",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/angular",
@@ -21,8 +21,8 @@
     "rxjs": "^6.5.5 || ^7.x"
   },
   "dependencies": {
-    "@sentry/browser": "9.0.0-alpha.0",
-    "@sentry/core": "9.0.0-alpha.0",
+    "@sentry/browser": "9.0.0-alpha.1",
+    "@sentry/core": "9.0.0-alpha.1",
     "tslib": "^2.4.1"
   },
   "devDependencies": {

diff --git a/packages/astro/package.json b/packages/astro/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/astro",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for Astro",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/astro",
@@ -56,9 +56,9 @@
     "astro": ">=3.x || >=4.0.0-beta || >=5.x"
   },
   "dependencies": {
-    "@sentry/browser": "9.0.0-alpha.0",
-    "@sentry/core": "9.0.0-alpha.0",
-    "@sentry/node": "9.0.0-alpha.0",
+    "@sentry/browser": "9.0.0-alpha.1",
+    "@sentry/core": "9.0.0-alpha.1",
+    "@sentry/node": "9.0.0-alpha.1",
     "@sentry/vite-plugin": "^2.22.6"
   },
   "devDependencies": {

diff --git a/packages/aws-serverless/package.json b/packages/aws-serverless/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/aws-serverless",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for AWS Lambda and AWS Serverless Environments",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/serverless",
@@ -68,8 +68,8 @@
     "@opentelemetry/instrumentation": "^0.57.1",
     "@opentelemetry/instrumentation-aws-lambda": "0.50.2",
     "@opentelemetry/instrumentation-aws-sdk": "0.49.0",
-    "@sentry/core": "9.0.0-alpha.0",
-    "@sentry/node": "9.0.0-alpha.0",
+    "@sentry/core": "9.0.0-alpha.1",
+    "@sentry/node": "9.0.0-alpha.1",
     "@types/aws-lambda": "^8.10.62"
   },
   "devDependencies": {

diff --git a/packages/browser-utils/package.json b/packages/browser-utils/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-utils",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Browser Utilities for all Sentry JavaScript SDKs",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/browser-utils",
@@ -39,7 +39,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/core": "9.0.0-alpha.0"
+    "@sentry/core": "9.0.0-alpha.1"
   },
   "scripts": {
     "build": "run-p build:transpile build:types",

diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/browser",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for browsers",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/browser",
@@ -39,14 +39,14 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry-internal/browser-utils": "9.0.0-alpha.0",
-    "@sentry-internal/feedback": "9.0.0-alpha.0",
-    "@sentry-internal/replay": "9.0.0-alpha.0",
-    "@sentry-internal/replay-canvas": "9.0.0-alpha.0",
-    "@sentry/core": "9.0.0-alpha.0"
+    "@sentry-internal/browser-utils": "9.0.0-alpha.1",
+    "@sentry-internal/feedback": "9.0.0-alpha.1",
+    "@sentry-internal/replay": "9.0.0-alpha.1",
+    "@sentry-internal/replay-canvas": "9.0.0-alpha.1",
+    "@sentry/core": "9.0.0-alpha.1"
   },
   "devDependencies": {
-    "@sentry-internal/integration-shims": "9.0.0-alpha.0",
+    "@sentry-internal/integration-shims": "9.0.0-alpha.1",
     "fake-indexeddb": "^4.0.1"
   },
   "scripts": {

diff --git a/packages/bun/package.json b/packages/bun/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/bun",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for bun",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/bun",
@@ -39,9 +39,9 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/core": "9.0.0-alpha.0",
-    "@sentry/node": "9.0.0-alpha.0",
-    "@sentry/opentelemetry": "9.0.0-alpha.0"
+    "@sentry/core": "9.0.0-alpha.1",
+    "@sentry/node": "9.0.0-alpha.1",
+    "@sentry/opentelemetry": "9.0.0-alpha.1"
   },
   "devDependencies": {
     "bun-types": "latest"

diff --git a/packages/cloudflare/package.json b/packages/cloudflare/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/cloudflare",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for Cloudflare Workers and Pages",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/cloudflare",
@@ -39,7 +39,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/core": "9.0.0-alpha.0"
+    "@sentry/core": "9.0.0-alpha.1"
   },
   "optionalDependencies": {
     "@cloudflare/workers-types": "^4.x"

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/core",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Base implementation for all Sentry JavaScript SDKs",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/core",

diff --git a/packages/core/src/tracing/sampling.ts b/packages/core/src/tracing/sampling.ts
@@ -41,7 +41,12 @@ export function sampleSpan(
   const parsedSampleRate = parseSampleRate(sampleRate);
 
   if (parsedSampleRate === undefined) {
-    DEBUG_BUILD && logger.warn('[Tracing] Discarding transaction because of invalid sample rate.');
+    DEBUG_BUILD &&
+      logger.warn(
+        `[Tracing] Discarding root span because of invalid sample rate. Sample rate must be a boolean or a number between 0 and 1. Got ${JSON.stringify(
+          sampleRate,
+        )} of type ${JSON.stringify(typeof sampleRate)}.`,
+      );
     return [false];
   }
 

diff --git a/packages/core/src/utils/hasTracingEnabled.ts b/packages/core/src/utils/hasTracingEnabled.ts
@@ -20,7 +20,7 @@ export function hasTracingEnabled(
   const options = maybeOptions || client?.getOptions();
   return (
     !!options &&
-    // Note: This check is `!= null`, meaning "nullish"
+    // Note: This check is `!= null`, meaning "nullish". `0` is not "nullish", `undefined` and `null` are. (This comment was brought to you by 15 minutes of questioning life)
     (options.tracesSampleRate != null || !!options.tracesSampler)
   );
 }
diff --git a/packages/core/src/utils/parseSampleRate.ts b/packages/core/src/utils/parseSampleRate.ts
@@ -1,6 +1,3 @@
-import { DEBUG_BUILD } from '../debug-build';
-import { logger } from '../utils-hoist/logger';
-
 /**
  * Parse a sample rate from a given value.
  * This will either return a boolean or number sample rate, if the sample rate is valid (between 0 and 1).
@@ -15,12 +12,6 @@ export function parseSampleRate(sampleRate: unknown): number | undefined {
 
   const rate = typeof sampleRate === 'string' ? parseFloat(sampleRate) : sampleRate;
   if (typeof rate !== 'number' || isNaN(rate) || rate < 0 || rate > 1) {
-    DEBUG_BUILD &&
-      logger.warn(
-        `[Tracing] Given sample rate is invalid. Sample rate must be a boolean or a number between 0 and 1. Got ${JSON.stringify(
-          sampleRate,
-        )} of type ${JSON.stringify(typeof sampleRate)}.`,
-      );
     return undefined;
   }
 

diff --git a/packages/deno/package.json b/packages/deno/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/deno",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for Deno",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/deno",
@@ -24,7 +24,7 @@
     "/build"
   ],
   "dependencies": {
-    "@sentry/core": "9.0.0-alpha.0"
+    "@sentry/core": "9.0.0-alpha.1"
   },
   "scripts": {
     "deno-types": "node ./scripts/download-deno-types.mjs",

diff --git a/packages/ember/package.json b/packages/ember/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@sentry/ember",
-  "version": "9.0.0-alpha.0",
+  "version": "9.0.0-alpha.1",
   "description": "Official Sentry SDK for Ember.js",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/ember",
@@ -32,8 +32,8 @@
   "dependencies": {
     "@babel/core": "^7.24.4",
     "@embroider/macros": "^1.16.0",
-    "@sentry/browser": "9.0.0-alpha.0",
-    "@sentry/core": "9.0.0-alpha.0",
+    "@sentry/browser": "9.0.0-alpha.1",
+    "@sentry/core": "9.0.0-alpha.1",
     "ember-auto-import": "^2.7.2",
     "ember-cli-babel": "^8.2.0",
     "ember-cli-htmlbars": "^6.1.1",