Skip to content

Commit

Permalink
avoid optional chaining
Browse files Browse the repository at this point in the history
  • Loading branch information
Lms24 committed Jan 31, 2025
1 parent af58f35 commit 7a2561b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/react/src/tanstackrouter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ export function tanstackRouterBrowserTracingIntegration(
if (instrumentNavigation) {
// The onBeforeNavigate hook is called at the very beginning of a navigation and is only called once per navigation, even when the user is redirected
castRouterInstance.subscribe('onBeforeNavigate', onBeforeNavigateArgs => {
const fromLocationState = onBeforeNavigateArgs.fromLocation && onBeforeNavigateArgs.fromLocation.state;
// onBeforeNavigate is called during pageloads. We can avoid creating navigation spans by comparing the states of the to and from arguments.
if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation?.state) {
if (onBeforeNavigateArgs.toLocation.state === fromLocationState) {
return;
}

Expand Down

0 comments on commit 7a2561b

Please sign in to comment.