build(android): Bump compileSdk and targetSdk to API 37 (Android 17)#5768
Open
runningcode wants to merge 12 commits into
Open
build(android): Bump compileSdk and targetSdk to API 37 (Android 17)#5768runningcode wants to merge 12 commits into
runningcode wants to merge 12 commits into
Conversation
Bump the default AGP fallback to 9.2.1, refresh the AGP-compat matrix, and add AGP 9 migration opt-outs until we adopt built-in Kotlin and the new DSL. Includes AGP 9 compatibility fixes for replay and compose modules. Co-authored-by: Cursor <cursoragent@cursor.com>
Officially support Android 17 by raising SDK levels, resolving AGP 9.2 lint findings, pinning Robolectric tests that lag compileSdk 37, and updating Sauce device-farm configs. Co-authored-by: Cursor <cursoragent@cursor.com>
Add the PR link Danger requires in CHANGELOG.md and rerun screenshot unit tests when Gradle cache omits the test-snapshots output directory. Co-authored-by: Cursor <cursoragent@cursor.com>
Use :test with --no-configuration-cache when snapshots are missing, and skip the sentry-cli upload with a warning instead of failing the job. Co-authored-by: Cursor <cursoragent@cursor.com>
Rerunning a single Android unit-test task after check is unreliable with configuration cache. Warn and skip the sentry-cli upload instead of failing the Build workflow when the directory is absent. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore build.yml, Sauce configs, AGENTS.md, root build.gradle.kts, and the distribution module build script to main so this PR carries only the core Android 17 API bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
Set jvmToolchain(8) for the navigation, replay, sqlite, and apache http client modules so the Kotlin compile toolchain is fixed under the Android 17 build, and import JvmTarget/KotlinVersion instead of using fully-qualified references. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add jvmToolchain(8) to the fragment and timber modules and import JvmTarget/KotlinVersion instead of using fully-qualified references, matching the other Android modules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The jvmToolchain(8) pin forced javac onto JDK 8, where Error Prone (compiled for JDK 11) cannot load, breaking :sentry-apache-http-client-5 :compileJava and every Spring Boot sample build. Keep jvmTarget at 1.8 for Java 8 bytecode while letting the compiler run on the daemon JDK. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b193867 | 319.59 ms | 403.09 ms | 83.50 ms |
| 2124a46 | 319.19 ms | 415.04 ms | 95.85 ms |
| a5ab36f | 316.83 ms | 394.54 ms | 77.71 ms |
| dba088c | 320.59 ms | 361.29 ms | 40.70 ms |
| 4e3e79d | 328.10 ms | 395.64 ms | 67.54 ms |
| abfcc92 | 309.54 ms | 380.32 ms | 70.78 ms |
| 539ca63 | 313.51 ms | 355.43 ms | 41.92 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| bb0ff41 | 312.86 ms | 363.78 ms | 50.92 ms |
| 2195398 | 319.02 ms | 342.38 ms | 23.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b193867 | 1.58 MiB | 2.19 MiB | 620.00 KiB |
| 2124a46 | 1.58 MiB | 2.12 MiB | 551.51 KiB |
| a5ab36f | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
| 4e3e79d | 0 B | 0 B | 0 B |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 539ca63 | 1.58 MiB | 2.12 MiB | 551.41 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| bb0ff41 | 0 B | 0 B | 0 B |
| 2195398 | 0 B | 0 B | 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
compileSdkandtargetSdkto API 37 (Android 17) and raises the minimum AGP to 9.1.1 for the Android 17 toolchain.This is a slimmed-down version of
feat/android-17-api-bump, excluding the CI, tooling, and distribution-module changes (build.yml, Sauce configs,AGENTS.md, rootbuild.gradle.kts, andsentry-android-distribution/build.gradle.kts) so it carries only the core API bump.🤖 Generated with Claude Code