-
-
Notifications
You must be signed in to change notification settings - Fork 465
feat(metrics): [Trace Metrics 10] Metrics Gauge API #4989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 12-18-metrics_distribution_api
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- [Trace Metrics 10] Metrics Gauge API ([#4989](https://github.com/getsentry/sentry-java/pull/4989))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
95094ac to
c1dee70
Compare
ac14e6d to
06634d4
Compare
markushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| @Override | ||
| public void gauge(final @NotNull String name, final @Nullable Double value) { | ||
| captureMetrics(SentryLogParameters.create(null, null), name, "gauge", value, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, could make sense to have a SentryLogParameters.create() method without any arguments
c1dee70 to
ece88f1
Compare
06634d4 to
661415a
Compare

📜 Description
Add
gaugemetrics API methods.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps