New User Feedback form #4384
Open
New User Feedback form #4384
+953
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Scopes.captureFeedback API Changed the MainActivity sample app to use the new API
captureFeedback does not update scope lastEventId anymore
added SentryOptions.beforeSendFeedback implemented SentryClient.captureFeedback
# Conflicts: # CHANGELOG.md # sentry/api/sentry.api # sentry/src/main/java/io/sentry/SentryClient.java
added first draft of SentryUserFeedbackDialog
…idget # Conflicts: # CHANGELOG.md
added feedbackOptions to SentryOptions added callbacks to SentryUserFeedbackDialog
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a83c559 | 459.20 ms | 529.53 ms | 70.34 ms |
| 9f19891 | 402.73 ms | 525.00 ms | 122.27 ms |
| ded4b06 | 409.00 ms | 469.23 ms | 60.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a83c559 | 1.58 MiB | 2.09 MiB | 515.74 KiB |
| 9f19891 | 1.58 MiB | 2.09 MiB | 515.84 KiB |
| ded4b06 | 1.58 MiB | 2.09 MiB | 517.61 KiB |
added feedback message truncation SentryClient doesn't check for backfillable feedbacks anymore
…idget # Conflicts: # CHANGELOG.md
added dialog theme to sample app MainActivity "send user feedback" button now opens feedback dialog instead of sending feedback
# Conflicts: # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java # sentry/api/sentry.api # sentry/src/main/java/io/sentry/HubAdapter.java # sentry/src/main/java/io/sentry/HubScopesWrapper.java # sentry/src/main/java/io/sentry/IScopes.java # sentry/src/main/java/io/sentry/NoOpHub.java # sentry/src/main/java/io/sentry/NoOpScopes.java # sentry/src/main/java/io/sentry/Scopes.java # sentry/src/main/java/io/sentry/ScopesAdapter.java # sentry/src/main/java/io/sentry/SentryClient.java # sentry/src/main/java/io/sentry/transport/RateLimiter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Continuation of #4286
Add the new User Feedback form (an AlertDialog)
Add all relevant options for customizations and callbacks
How the form is shown in the example app with light theme and no customization
How the form is shown in the example app with dark theme and no customization
How the form is shown in the example app with (pretty bad) customization
💡 Motivation and Context
Implements first part of #3613
💚 How did you test it?
to do
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Next PR will have the widget (the button that actually show the form)
After that, we'll have screenshots and whatever